Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[package] yaml-cpp/all: wrong cmake name according to upstream #405

Closed
gocarlos opened this issue Nov 29, 2019 · 4 comments
Closed

[package] yaml-cpp/all: wrong cmake name according to upstream #405

gocarlos opened this issue Nov 29, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@gocarlos
Copy link
Contributor

upstream is using yaml::yaml and yaml-cpp -> https://github.com/jbeder/yaml-cpp/blob/master/CMakeLists.txt#L64
conan is using yaml-cpp::yaml-cpp as target name in cmake
@gocarlos gocarlos added the bug Something isn't working label Nov 29, 2019
@uilianries uilianries mentioned this issue Nov 29, 2019
Closed
1 task
@gocarlos gocarlos mentioned this issue Nov 29, 2019
Closed
@gocarlos
Copy link
Contributor Author

eventually fixing this upstream: jbeder/yaml-cpp#792

@gocarlos
Copy link
Contributor Author

Fixed upstream master... waiting for release

@gocarlos
Copy link
Contributor Author

gocarlos commented Dec 2, 2019

closing this issue as master upstream is now the same target name as conan

@gocarlos gocarlos closed this as completed Dec 2, 2019
@uilianries
Copy link
Member

Thanks @gocarlos !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gocarlos @uilianries