cryptopp: Apply ARM fix on MSVC #26208
Open
+319
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
commented
Dec 19, 2024
There was a problem hiding this comment.
Changed so it's git apply-able
AbrilRBS
commented
Dec 19, 2024
…BS/conan-center-index into ar/cryptopp-cmake-arm-windows-fix
AbrilRBS
commented
Dec 19, 2024
There was a problem hiding this comment.
Had to change the file so versions were exported (Issue already tracked internally), so took the chance to clean it up - I was tempted to remove old versions but decided not to in the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: cryptopp/[8.9.0]
Motivation
Closes #26205, see there for discussion and reasonale
Note that we might want to backport this fix for other versions too, but will check with the team if we want to support old configurations that upstream would have not been able to test either way
Details
Upstream fixed asm usage for MSVC in arm archs in abdes/cryptopp-cmake@1940cc0, this patch backports it
Note that as described in the issue, I locally get compilation errors unless I define
CRYPTOPP_ARM_ACLE_HEADERto 0, which seems to be unrealted (TODO: Link upstream issue for traceability). Will leave this as draft at first until we decide if that can go in a different PR, if anySuccessful compilation logs: (With the extra
-DCRYPTOPP_ARM_ACLE_HEADER=0)successful_ninja_arm.log