add adapter option #165
Closed
add adapter option #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
| @@ -25,7 +25,7 @@ Karma auto loads plugins unless you specify a plugins config. If you have one, y | |||
| plugins: ['karma-jspm', 'karma-phantomjs-launcher'], | |||
| ``` | |||
|
|
|||
| The `loadFiles` configuration tells karma-jspm which files should be dynamically loaded via systemjs *before* the tests run. Globs or regular file paths are acceptable. | |||
| The `loadFiles` configuration tells karma-jspm which files should be dynamically loaded via systemjs *before* the tests run. Globs or regular file paths are acceptable. | |||
There was a problem hiding this comment.
this is my WebStorm IDE adding a space, sorry
|
What do you need to do in a custom karma-jspm adapter that can't be done in a regular included JS file or a separate plugin? |
|
There is a race condition with files served ( and loaded ). I'm using the systemjs loader promise to ensure files are loaded prior to karma.start is called. Plus, there are angular2 conventions used to initiated unit tests. |
RavenNumber of Findings: 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #164 and potentially #162.
This is a non-breaking change in that if no custom adapter is provided, the default adapter is used.
A sample implementation is here: https://github.com/UIUXEngineering/angular2-seed-jspm/blob/master/src/client/jspm.karma.ng2.adapter.js