Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom adapter option #164

Open
jerryorta-dev opened this issue Jun 29, 2016 · 1 comment
Open

Add custom adapter option #164

jerryorta-dev opened this issue Jun 29, 2016 · 1 comment

Comments

@jerryorta-dev
Copy link

jerryorta-dev commented Jun 29, 2016

I want to keep all benefits that karma-jspm offers, but would like the opportunity to develop a little lower level by writing my own adapters as necessary.

For angular2 with typescript tests I'm finding it necessary to write a custom adapter.

I have a PR ready, and have a sample implementation at https://github.com/UIUXEngineering/angular2-seed-jspm/blob/master/src/client/jspm.karma.ng2.adapter.js.

This is a non-breaking change in that if no custom adapter is provided, the default adapter is used.

This may also help with #162

@RIAstar
Copy link

RIAstar commented Jun 30, 2016

Unfortunately, the PR won't help with #162 because that bug causes none of the files to be loaded at all. That would include the custom adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants