Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next steps plugin implementation #53

Closed
constantinpape opened this issue Nov 17, 2024 · 2 comments · Fixed by #55
Closed

Next steps plugin implementation #53

constantinpape opened this issue Nov 17, 2024 · 2 comments · Fixed by #55
Assignees

Comments

@constantinpape
Copy link
Contributor

constantinpape commented Nov 17, 2024

  • Handle resolution and rescaling correctly.
    • Read resolution from input file if possible (for mrc / rec).
    • Otherwise use optional input parameter in plugin.
    • Determine correct scaling based on average resolution model was trained on. (Need to aggregate this information).
    • Use the resolution in the distance measurement plugin.
  • Upload all models and connect them in the plugin.
    • I will put them in a folder on our drive.
    • Aggregate the training information, including average resolution (see prev. point).
    • Distinguish the different vesicle models: vesicles, vesicles_2d, vesicles_cryo
  • Improve handling of tiling:
    • Use get_default_tiling to determine the tiling values in the plugin.
    • Update the tiling for the 2D model to be at least 512 x 512.
  • Use napari progressbars instead of tqdm to display activity in napari. This is simple by replacing import tqdm with
try:
    from napari.utils import progress as tqdm
except ImportError:
    from tqdm import tqdm
@lufre1
Copy link
Contributor

lufre1 commented Nov 18, 2024

to use the napari progress bar we need to adapt https://github.com/constantinpape/torch-em/blob/4f7b180af8177da9f1c1c5b09b282f7c270a1249/torch_em/util/prediction.py#L7 in torch-em

@constantinpape
Copy link
Contributor Author

to use the napari progress bar we need to adapt https://github.com/constantinpape/torch-em/blob/4f7b180af8177da9f1c1c5b09b282f7c270a1249/torch_em/util/prediction.py#L7 in torch-em

Can you make a PR in torch_em for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants