-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matches-selector published to npm (at least) 3 times #10
Comments
@ForbesLindesay is already an org member so he should be able to do it himself. |
I think there is a dependency missing in NPM (should be query). Which was my reason to publish my own |
I inlined |
@ForbesLindesay query dependency isn't silly if your app supports IE8 etc. |
+1 but doesn't really matter to me I don't use any of them out of npm now |
@visionmedia does that mean you're actually using component for real now? |
yup! |
cool, so can we get a resolution here? If you insist on keeping a fork for the sake of removing a single dependency (I'm not really sure why it's important to remove it?) perhaps @ForbesLindesay and @visionmedia could swap repo names so the 'official' repo doesn't have the trailing |
@azer http://caniuse.com/#feat=queryselector http://caniuse.com/css-sel3 you only need |
sounds good to me, you could always use "component/matches-selector" in npm but then you're stuck with git |
Any update on this one? Seems like it should be pretty easy to resolve. |
@visionmedia @azer @ForbesLindesay can we sort out this madness please?
component/matches-selector is now published on npm in 3 different variants:
From these 3 repos:
They're all (mostly) the same damn code.
Now I'm sure this happened because everyone needed a solution asap, I'm not suggesting anyone screwed up, but can we take a moment to detangle?
Ideal solution (please guys):
azer:
ForbesLindesay:
visionmedia:
Reasonable request?
The text was updated successfully, but these errors were encountered: