Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matches-selector published to npm (at least) 3 times #10

Open
timoxley opened this issue Sep 27, 2013 · 11 comments
Open

matches-selector published to npm (at least) 3 times #10

timoxley opened this issue Sep 27, 2013 · 11 comments

Comments

@timoxley
Copy link
Member

@visionmedia @azer @ForbesLindesay can we sort out this madness please?

component/matches-selector is now published on npm in 3 different variants:

  • matches-dom-selector
  • matches-selector
  • matches-selector-2

From these 3 repos:

They're all (mostly) the same damn code.

Now I'm sure this happened because everyone needed a solution asap, I'm not suggesting anyone screwed up, but can we take a moment to detangle?

Ideal solution (please guys):

azer:

  1. unpublish matches-dom-selector

ForbesLindesay:

  1. unpublish matches-selector

visionmedia:

  1. Unpublish matches-selector-2
  2. Add the package.json from matches-selector-2 to component/matches-selector
  3. Rename name 'matches-selector-2' in package.json:
  4. republish to npm under matches-selector name
  5. Consider adding @ForbesLindesay & @azer as collaborators on component/matches-selector to maintain the package.json for browserify/npm compatibility.

Reasonable request?

@jonathanong
Copy link
Contributor

@ForbesLindesay is already an org member so he should be able to do it himself.

@azer
Copy link

azer commented Oct 16, 2013

I think there is a dependency missing in NPM (should be query). Which was my reason to publish my own

@ForbesLindesay
Copy link

I inlined query in my version because the code to just do it directly was shorter than the code to use an additional module. I'm happy to collaborate with other people to maintain my branch. I don't have any real intentions to deviate from this module's API, but the dependency on query is silly and just trying to make a point, so I'm not going to change that.

@azer
Copy link

azer commented Oct 19, 2013

@ForbesLindesay query dependency isn't silly if your app supports IE8 etc.

@tj
Copy link
Member

tj commented Oct 19, 2013

+1 but doesn't really matter to me I don't use any of them out of npm now

@timoxley
Copy link
Member Author

@visionmedia does that mean you're actually using component for real now?

@tj
Copy link
Member

tj commented Oct 19, 2013

yup!

@timoxley
Copy link
Member Author

cool, so can we get a resolution here? If you insist on keeping a fork for the sake of removing a single dependency (I'm not really sure why it's important to remove it?) perhaps @ForbesLindesay and @visionmedia could swap repo names so the 'official' repo doesn't have the trailing -2? possible?

@jonathanong
Copy link
Contributor

@azer http://caniuse.com/#feat=queryselector http://caniuse.com/css-sel3 you only need query if you're using css3 selectors and such, which i personally never use to match

@tj
Copy link
Member

tj commented Oct 19, 2013

sounds good to me, you could always use "component/matches-selector" in npm but then you're stuck with git

@TooTallNate
Copy link
Member

Any update on this one? Seems like it should be pretty easy to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants