Remove unused code #356
Merged
Remove unused code #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
mcbarton
force-pushed
the
remove-redundant-code
branch
from
3e57dd2 to
e4c8677
Compare
mcbarton
force-pushed
the
remove-redundant-code
branch
from
e4c8677 to
766b845
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
==========================================
+ Coverage 74.55% 76.31% +1.75%
==========================================
Files 8 8
Lines 3211 3137 -74
==========================================
Hits 2394 2394
+ Misses 817 743 -74
|
|
@alexander-penev there may be more unused code in CppInterOp, but I'll remove it in a series of PRs. This PR will focus of paths.cpp and paths.h and is ready for review. |
|
@alexander-penev ping |
alexander-penev
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to remove what looks like unused code (I couldn't find reference to this code being used in CppInterOp, cppyy-backend,CPyCppyy, cppyy or xeus-cpp). We should see an increase in coverage if this PR works.