Add variadic support for templates #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
==========================================
- Coverage 76.31% 76.28% -0.04%
==========================================
Files 8 8
Lines 3137 3141 +4
==========================================
+ Hits 2394 2396 +2
- Misses 743 745 +2
|
aaronj0
force-pushed
the
variadic-support
branch
from
e87e146 to
9412530
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
aaronj0
force-pushed
the
variadic-support
branch
from
9412530 to
2ef2734
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
reviewed
Sep 20, 2024
There is an added unittest... It is still a draft though, will update with a case for |
aaronj0
force-pushed
the
variadic-support
branch
from
2ef2734 to
3603d06
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
reviewed
Dec 4, 2024
| TEST(FunctionReflectionTest, InstantiateVariadicFunctionTemplate) { | ||
| std::vector<Decl*> Decls; | ||
| std::string code = R"( | ||
| template<typename... Args> void VariadicFnTemplate(Args... args) {} |
There was a problem hiding this comment.
Can we include the example of #305?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.