Rewrite the "representing types" section to be more comprehensive

compiler-errors · May 31, 2024 · 4a705f9 · 4a705f9
1 parent ea35ee8
commit 4a705f9
Show file tree

Hide file tree

Showing 11 changed files with 508 additions and 342 deletions.
diff --git a/src/SUMMARY.md b/src/SUMMARY.md
@@ -119,19 +119,20 @@
     - [Early vs Late bound parameters](./early-late-bound-params/early-late-bound-summary.md)
         - [Implementation nuances of early/late bound parameters](./early-late-bound-params/early-late-bound-implementation-nuances.md)
         - [Interactions with turbofishing](./early-late-bound-params/turbofishing-and-early-late-bound.md)
-    - [`TypeFolder` and `TypeFoldable`](./ty-fold.md)
-    - [Generic arguments](./generic_arguments.md)
+- [The `ty` module: representing types](./ty.md)
+    - [ADTs and Generic Arguments](./ty_module/generic_arguments.md)
+    - [Parameter types/consts/regions](./ty_module/param_ty_const_regions.md)
+    - [`EarlyBinder` and instantiating parameters](./ty_module/early_binder.md)
+    - [`Binder` and Higher ranked regions](./ty_module/binders.md)
+    - [Instantiating binders](./ty_module/instantiating_binders.md)
     - [Constants in the type system](./constants.md)
-    - [Bound vars and Parameters](./bound-vars-and-params.md)
+- [`TypeFolder` and `TypeFoldable`](./ty-fold.md)
 - [Parameter Environments](./param_env/param_env_summary.md)
     - [What is it?](./param_env/param_env_what_is_it.md)
     - [How are `ParamEnv`'s constructed internally](./param_env/param_env_construction_internals.md)
     - [Which `ParamEnv` do I use?](./param_env/param_env_acquisition.md)
 - [Type inference](./type-inference.md)
 - [Trait solving](./traits/resolution.md)
-    - [Early and Late Bound Parameter Definitions](./early-late-bound-params/early-late-bound-summary.md)
-        - [Implementation nuances of early/late bound parameters](./early-late-bound-params/early-late-bound-implementation-nuances.md)
-        - [Interactions with turbofishing](./early-late-bound-params/turbofishing-and-early-late-bound.md)
     - [Higher-ranked trait bounds](./traits/hrtb.md)
     - [Caching subtleties](./traits/caching.md)
     - [Implied bounds](./traits/implied-bounds.md)

diff --git a/src/bound-vars-and-params.md b/src/bound-vars-and-params.md
diff --git a/src/generic_arguments.md b/src/generic_arguments.md
diff --git a/src/generics.md b/src/generics.md
diff --git a/src/ty-fold.md b/src/ty-fold.md
@@ -1,9 +1,8 @@
 # `TypeFoldable` and `TypeFolder`
 
-How is this `subst` query actually implemented? As you can imagine, we might want to do
-substitutions on a lot of different things. For example, we might want to do a substitution directly
-on a type like we did with `Vec` above. But we might also have a more complex type with other types
-nested inside that also need substitutions.
+In the previous chapter we discussed instantiating binders. This must involves looking at everything inside of a `Early/Binder`
+to find any usages of the bound vars in order to replace them. Binders can wrap an arbitrary rust type `T` not just a `Ty` so
+how do we implement the `instantiate` methods on the `Early/Binder` types.
 
 The answer is a couple of traits:
 [`TypeFoldable`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/fold/trait.TypeFoldable.html)