Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/improve introspection #40

Merged
merged 9 commits into from
Jul 8, 2020
Merged

Features/improve introspection #40

merged 9 commits into from
Jul 8, 2020

Conversation

MohamedBeydoun
Copy link
Member

Closes #39

@MohamedBeydoun MohamedBeydoun added the enhancement New feature or request label Jun 25, 2020
@MohamedBeydoun MohamedBeydoun self-assigned this Jun 25, 2020
@MohamedBeydoun MohamedBeydoun linked an issue Jun 26, 2020 that may be closed by this pull request
Improve authorization #39
Open
ValerianClerc
ValerianClerc requested changes Jun 28, 2020
View reviewed changes
Copy link
Member

@ValerianClerc ValerianClerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, I like the implementation of the design that we discussed. Just a few changes, but no big picture issues from me.

src/controllers/auth.ts Outdated Show resolved Hide resolved
src/util/auth.ts Show resolved Hide resolved
src/controllers/auth.ts Outdated Show resolved Hide resolved
src/util/auth.ts Outdated Show resolved Hide resolved
src/util/auth.ts Outdated Show resolved Hide resolved
src/util/auth.ts Outdated Show resolved Hide resolved
@ValerianClerc
Copy link
Member

Awesome, LGTM. I'll approve once you add tests

@MohamedBeydoun MohamedBeydoun changed the title [WIP] Features/improve introspection Features/improve introspection Jul 8, 2020
@MohamedBeydoun MohamedBeydoun merged commit 64f4c34 into dev Jul 8, 2020
@MohamedBeydoun MohamedBeydoun deleted the features/improve-introspection branch July 8, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValerianClerc ValerianClerc ValerianClerc approved these changes

Assignees

@MohamedBeydoun MohamedBeydoun

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve authorization
2 participants
@MohamedBeydoun @ValerianClerc