feat(pbr): improvements to terrain parallax and parallax shadows#982
Merged
Conversation
doodlum
approved these changes
Mar 2, 2025
alandtse
pushed a commit
to alandtse/open-shaders
that referenced
this pull request
Jul 20, 2025
…munity-shaders#982) * feat(pbr): improvements to terrain parallax and parallax shadows * style: 🎨 apply clang-format changes * Update ExtendedMaterials.hlsli * Update ExtendedMaterials.hlsli * pow 2 instead of mul 2 parallax shadow * style: 🎨 apply clang-format changes --------- Co-authored-by: ThePagi <ThePagi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use min instead of max when selecting parallax mipmap - this improves quality a ton especially on pbr landscapes, because the view angle and absence of anisotropic filtering made it always pick too small mipmaps before. Potentially lowers performance, but no real loss noticed when testing and we can reduce parallax resolution further now that it is crispy.
Changed height blending to make it much stronger while keeping smooth transitions on flatter parallax.
Fixed pbr landscape parallax shadows that were too weak because they were not normalized like all other parallax shadows were.
Edit: changed parallax shadow *2 multiplier to ^2 for more demure behavior