feat: improve subtle shading#976
Merged
Merged
Conversation
alandtse
pushed a commit
to alandtse/open-shaders
that referenced
this pull request
Jul 20, 2025
* feat(skylighting): improved skylighting * fix(grass lighting): grass shading * style: 🎨 apply clang-format changes * chore: tweak defaults * chore: skip skylighting in interiors * style: 🎨 apply clang-format changes * fix: grass shading * style: 🎨 apply clang-format changes * chore: more shading improvements * style: 🎨 apply clang-format changes * chore: tweak ssgi * chore: tonemapping tweaks * chore: increase ao power * chore: reduce ao power * feat(skylighting): fixed tree darkness * chore: lower skylighting amount * style: 🎨 apply clang-format changes * chore: cleanup * style: 🎨 apply clang-format changes * chore: make grass sss consistent with vanilla * chore: improved GI * chore: grass tweaks * chore: skylighting tweaks * chore: add shadow bias to skylighting * chore: no ssgi dimmer * chore: less aggressive skylighting * chore: less aggressive skylighting curve * chore: remove skylighting tangent weights * chore: improved skylighting bias * chore: better skylighting curve * style: 🎨 apply clang-format changes * fix: water shadow * chore: tweaks to improve snow AO * style: 🎨 apply clang-format changes * chore: remove more baked lighting * style: 🎨 apply clang-format changes * chore: wrapped lighting for grass * style: 🎨 apply clang-format changes * chore: tweak grass defaults * chore: more to reduce overdarkening * chore: compensate for less thick ao * style: 🎨 apply clang-format changes * chore: more to mitigate snow darkness * style: 🎨 apply clang-format changes * chore: remove sqrt * style: 🎨 apply clang-format changes * chore: reduce gi strength * chore: change specular skylighting sample direction * chore: tweak more grass lighting defaults * chore: decrease specular * fix: enderal trees lighting * feat: improved specular AO * fix: skyboost * chore: brighten skylighting on trees * chore: brighten skylighting on trees * style: 🎨 apply clang-format changes * chore: brighten skylighting on all vertex ao * style: 🎨 apply clang-format changes * chore: tweak ao * feat: fix shadow bias via skylighting * style: 🎨 apply clang-format changes * fix: bad default grass settings * chore: redo skylighting boost * style: 🎨 apply clang-format changes * fix: upscaler shimmering * chore: put backlighting boost back * style: 🎨 apply clang-format changes * chore: revert gamma * fix: backlighting direction * feat: view dependant wrapping * style: 🎨 apply clang-format changes * chore: try to improve grass collision * style: 🎨 apply clang-format changes * feat: vanilla fresnel * chore: increase grass collision amount * fix: grass brightness * chore: less aggressive upscale color bias * fix: lighting in blackreach --------- Co-authored-by: doodlum <doodlum@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skylighting now boosts the ambient lighting from the sky relative to the minimum ambient.
Fixed skylighting light leakage.
Fixed grass shading on complex grass.
Improved grass shading with wrapped lighting.
SSGI multi-bounce.
Fixed DALC negatives.
Shadow bias fix via skylighting information.
Less intense AO when mixing vertex ao with skylighting.
Fixed tree darkness with skylighting.
Added SSS boost for soft/back/rim lighting.
Fixed water shadows.
Smoother grass collision.
Tweaked tonemapping.
Tweaked game SSAO.
Tweaked upscaling color bias.