Skip to content

fix(ci): resolve broken job name in shader validation workflow#2485

Merged
doodlum merged 3 commits into
devfrom
claude/silly-banach-6839e5
Jun 7, 2026
Merged

fix(ci): resolve broken job name in shader validation workflow#2485
doodlum merged 3 commits into
devfrom
claude/silly-banach-6839e5

Conversation

@doodlum

@doodlum doodlum commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Removed the single-entry matrix strategy from the shader-validation job in _shared-build.yaml
  • Inlined the "Flatrim" name and config file path directly into the job

Why

When the shader-validation job is skipped (because inputs.run-shader-validation is false), GitHub Actions doesn't expand matrix expressions — causing the job name to display as the raw literal ${{ matrix.config.name }} in the UI. Since the matrix only ever had one entry, removing it and inlining the values fixes the display without changing behavior.

Test plan

  • Verify the job name shows "Validate shader compilation (Flatrim)" in the PR checks UI
  • Confirm shader validation still runs correctly when triggered

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Simplified shader validation workflow to streamline the build pipeline with more consistent processing and cleaner artifact management.

The job name displayed raw `${{ matrix.config.name }}` when skipped
because GitHub doesn't expand matrix expressions for skipped jobs.
Remove the single-entry matrix strategy and inline the values directly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7a7b02b8-77c6-4b24-a4ae-4f0d3c354903

📥 Commits

Reviewing files that changed from the base of the PR and between b48bf24 and 9cc9b4f.

📒 Files selected for processing (1)
  • .github/workflows/_shared-build.yaml

📝 Walkthrough

Walkthrough

The shader-validation job in the shared build workflow is simplified from a matrix-based configuration that iterated over multiple validation configs to a single fixed validation run. The job header, cache key suffix, hardcoded config file path, and artifact naming are all updated to remove matrix dependencies.

Changes

Shader Validation Job Simplification

Layer / File(s) Summary
Shader validation job hardwiring
.github/workflows/_shared-build.yaml
The shader-validation job removes its matrix strategy and converts all matrix-derived values (job naming, cache suffix, config file selection, artifact naming) to fixed hardcoded values, reducing the job from dynamic multi-config iteration to a single static validation run.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • jiayev
  • SkrubbySkrubInAShrub

Poem

🐰 No more matrices to spin and dance,
One shader path gets its steady stance,
Cache keys simple, config now fixed,
Artifacts unified, no longer mixed!
The workflow hops forward, sleek and lean. ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/silly-banach-6839e5

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 actionlint (1.7.12)
.github/workflows/_shared-build.yaml

could not read ".github/workflows/_shared-build.yaml": open .github/workflows/_shared-build.yaml: no such file or directory

🔧 zizmor (1.25.2)
.github/workflows/_shared-build.yaml

INFO zizmor: 🌈 zizmor v1.25.2
fatal: no audit was performed
invalid input: .github/workflows/_shared-build.yaml

🔧 YAMLlint (1.38.0)
.github/workflows/_shared-build.yaml

[Errno 2] No such file or directory: '.github/workflows/_shared-build.yaml'

🔧 Checkov (3.2.530)
.github/workflows/_shared-build.yaml

2026-06-07 19:55:44,188 [MainThread ] [ERROR] Template file not found: .github/workflows/_shared-build.yaml
2026-06-07 19:55:44,192 [MainThread ] [ERROR] Template file not found: .github/workflows/_shared-build.yaml
2026-06-07 19:55:44,208 [MainThread ] [ERROR] Template file not found: .github/workflows/_shared-build.yaml
2026-06-07 19:55:44,236 [MainThread ] [WARNI] Secret scanning: could not process file .github/workflows/_shared-build.yaml
2026-06-07 19:55:44,217 [MainThread ] [ERROR] Failed to invoke function /usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner. with .github/workflows/_shared-build.yaml
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 88, in func_wrapper
result = original_func(item)
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner.py", line 74, in
resul

... [truncated 9199 characters] ...

r directory: '.github/workflows/_shared-build.yaml'
2026-06-07 19:55:44,254 [MainThread ] [ERROR] Exception traceback:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/main.py", line 647, in run
self.scan_reports = runner_registry.run(
^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/runner_registry.py", line 177, in run
for result in parallel_runner_results:
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 118, in _run_function_multiprocess_fork
raise v.internal_exception.with_traceback(v.internal_exception.traceback)
FileNotFoundError: [Errno 2] No such file or directory: '.github/workflows/_shared-build.yaml'


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

doodlum and others added 2 commits June 7, 2026 20:54
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…act name

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@doodlum doodlum merged commit a3e13d1 into dev Jun 7, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant