fix(ci): resolve broken job name in shader validation workflow#2485
Conversation
The job name displayed raw `${{ matrix.config.name }}` when skipped
because GitHub doesn't expand matrix expressions for skipped jobs.
Remove the single-entry matrix strategy and inline the values directly.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe shader-validation job in the shared build workflow is simplified from a matrix-based configuration that iterated over multiple validation configs to a single fixed validation run. The job header, cache key suffix, hardcoded config file path, and artifact naming are all updated to remove matrix dependencies. ChangesShader Validation Job Simplification
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 actionlint (1.7.12).github/workflows/_shared-build.yamlcould not read ".github/workflows/_shared-build.yaml": open .github/workflows/_shared-build.yaml: no such file or directory 🔧 zizmor (1.25.2).github/workflows/_shared-build.yamlINFO zizmor: 🌈 zizmor v1.25.2 🔧 YAMLlint (1.38.0).github/workflows/_shared-build.yaml[Errno 2] No such file or directory: '.github/workflows/_shared-build.yaml' 🔧 Checkov (3.2.530).github/workflows/_shared-build.yaml2026-06-07 19:55:44,188 [MainThread ] [ERROR] Template file not found: .github/workflows/_shared-build.yaml ... [truncated 9199 characters] ... r directory: '.github/workflows/_shared-build.yaml' Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…act name Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
shader-validationjob in_shared-build.yamlWhy
When the
shader-validationjob is skipped (becauseinputs.run-shader-validationis false), GitHub Actions doesn't expand matrix expressions — causing the job name to display as the raw literal${{ matrix.config.name }}in the UI. Since the matrix only ever had one entry, removing it and inlining the values fixes the display without changing behavior.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit