fix: dynamic cubemaps X4000 warning

[davo0411]

finally fixes x4000 issues per #2465

Summary by CodeRabbit

• Bug Fixes

  • Fixed uninitialized variable issues in shader computations.

• Refactor

  • Optimized dynamic cubemap and image-based lighting calculation flow for improved rendering performance and consistency across different rendering contexts.

[coderabbitai]

Wondering what really moved? Review this PR in Change Stack to inspect semantic changes, definitions, and references.

📝 Walkthrough

Walkthrough

This PR refactors static IBL control flow in the dynamic cubemaps shader by extracting the static IBL condition into a reusable boolean, optimizing early-exit paths, and ensuring proper initialization of specular variables in non-static IBL fallback code.

Changes

Static IBL Control Flow and Initialization

Layer / File(s)	Summary
Static IBL condition extraction and early-exit paths features/Dynamic\ Cubemaps/Shaders/DynamicCubemaps/DynamicCubemaps.hlsli	Extracted useStaticIBL boolean from inlined condition checks to eliminate repetition; optimized GetDynamicCubemapSpecularIrradiance to compute and return static specular irradiance early; changed GetDynamicCubemap to return the final specular result immediately when static IBL is available, replacing an accumulation pattern.
Non-static IBL path variable initialization features/Dynamic\ Cubemaps/Shaders/DynamicCubemaps/DynamicCubemaps.hlsli	Explicitly initialized envSpecular and skySpecular to 0.0 in non-static IBL sections of both functions instead of declaring them without initial values, ensuring deterministic behavior in fallback paths.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• community-shaders/skyrim-community-shaders#1535: Modifies DynamicCubemaps.hlsli specular IBL branching in the same dynamic cubemap shader code paths with overlapping control-flow changes.
• community-shaders/skyrim-community-shaders#2278: Both PRs modify DynamicCubemaps.hlsli initialization and branching in non-static IBL fallback paths to avoid uninitialized specular terms.
• community-shaders/skyrim-community-shaders#1283: Modifies GetDynamicCubemapSpecularIrradiance in the same file, affecting how specular and irradiance terms are computed and returned.

Suggested reviewers

• SkrubbySkrubInAShrub
• doodlum
• Pentalimbed

Poem

🐰 A cubemap stands with two bright paths,
Static IBL skips the math,
Boolean flags trim the code so clean,
Variables initialized—no undefined seen.
Specular shines both paths refined! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly references fixing a specific X4000 warning in dynamic cubemaps, which aligns with the changeset's refactoring of control flow and variable initialization in the DynamicCubemaps shader code.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[Copilot]

Pull request overview

This PR adjusts the Dynamic Cubemaps shader logic to eliminate an HLSL compiler warning (X4000) by ensuring variables are always initialized and by restructuring the static-IBL path to avoid relying on conditional early returns.

Changes:

• Introduces a useStaticIBL flag and routes control flow through an explicit if/else to handle static IBL vs dynamic evaluation.
• Initializes envSpecular and skySpecular to 0.0 in both affected functions to prevent “potentially uninitialized” warnings.
• Simplifies the static-IBL return in GetDynamicCubemap() to directly use specularIrradiance (equivalent behavior given the previous initialization).

[coderabbitai]

🧹 Nitpick comments (1)

features/Dynamic Cubemaps/Shaders/DynamicCubemaps/DynamicCubemaps.hlsli (1)

1-1: Consider adding an issue reference if applicable.

The PR title correctly follows conventional commits format. If this PR fixes a reported issue or implements a tracked feature request, please add an appropriate GitHub keyword to the PR description:

• "Fixes #XXX" or "Closes #XXX" for bug fixes
• "Implements #XXX" for features
• "Related to #XXX" for partial implementations

As per coding guidelines for this repository.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@features/Dynamic` Cubemaps/Shaders/DynamicCubemaps/DynamicCubemaps.hlsli at
line 1, The PR is missing a repository issue reference in its description;
please update the PR body to include the appropriate GitHub keyword (e.g.,
"Fixes #<issue>", "Implements #<issue>", or "Related to #<issue>") that
corresponds to the work in this change — this change touches the DynamicCubemaps
shader header (symbol DYNAMICCUBEMAPS_HLSLI in file DynamicCubemaps.hlsli) so
reference the relevant issue number and use the correct keyword in the PR
description.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@features/Dynamic` Cubemaps/Shaders/DynamicCubemaps/DynamicCubemaps.hlsli:
- Line 1: The PR is missing a repository issue reference in its description;
please update the PR body to include the appropriate GitHub keyword (e.g.,
"Fixes #<issue>", "Implements #<issue>", or "Related to #<issue>") that
corresponds to the work in this change — this change touches the DynamicCubemaps
shader header (symbol DYNAMICCUBEMAPS_HLSLI in file DynamicCubemaps.hlsli) so
reference the relevant issue number and use the correct keyword in the PR
description.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: cd42b51b-54df-4f4c-8f06-61e55dd0f16e

📥 Commits

Reviewing files that changed from the base of the PR and between e368f30 and 7145762.

📒 Files selected for processing (1)

• features/Dynamic Cubemaps/Shaders/DynamicCubemaps/DynamicCubemaps.hlsli