Skip to content

fix(vol-fog): missing define#2468

Merged
jiayev merged 1 commit into
community-shaders:devfrom
SkrubbySkrubInAShrub:shader-fix
Jun 4, 2026
Merged

fix(vol-fog): missing define#2468
jiayev merged 1 commit into
community-shaders:devfrom
SkrubbySkrubInAShrub:shader-fix

Conversation

@SkrubbySkrubInAShrub

@SkrubbySkrubInAShrub SkrubbySkrubInAShrub commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

fixes 18 shaders failing to compile.
followup on #2466

Summary by CodeRabbit

  • Chores
    • Updated shader configuration for improved rendering optimization.

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: aef10f77-4490-46e7-8010-11644b7d7da1

📥 Commits

Reviewing files that changed from the base of the PR and between 7cbe43f and f80896a.

📒 Files selected for processing (1)
  • package/Shaders/Sky.hlsl

📝 Walkthrough

Walkthrough

A single preprocessor macro alias is added to Sky.hlsl under the EXP_HEIGHT_FOG feature flag, defining SampColorSampler to reference SampBaseSampler. This enables consistent sampler naming within the exponential height fog implementation.

Changes

Exponential Height Fog Shader Setup

Layer / File(s) Summary
Sampler alias definition
package/Shaders/Sky.hlsl
When EXP_HEIGHT_FOG is enabled, SampColorSampler is defined as a preprocessor macro alias to SampBaseSampler, establishing the correct sampler reference for height fog rendering.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • jiayev

Poem

A rabbit hops through shader code so bright,
With samplers aliased, just right, just right!
One line of magic, SampColorSampler shines,
Exponential fog now perfectly aligns. 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(vol-fog): missing define' accurately describes the change: adding a missing preprocessor definition to fix shader compilation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

No actionable suggestions for changed features.

@jiayev jiayev merged commit c412e20 into community-shaders:dev Jun 4, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants