Skip to content

fix(i18n): add 'ready_for_review' type to pull request triggers#2467

Merged
SkrubbySkrubInAShrub merged 1 commit into
devfrom
fix-i18n-audit
Jun 3, 2026
Merged

fix(i18n): add 'ready_for_review' type to pull request triggers#2467
SkrubbySkrubInAShrub merged 1 commit into
devfrom
fix-i18n-audit

Conversation

@jiayev

@jiayev jiayev commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Improved pull request validation workflow for better development efficiency. Internationalization validation checks now trigger when pull requests transition to ready for review status and automatically skip for draft pull requests, ensuring quality checks happen at appropriate stages and reducing unnecessary processing overhead.

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4d0c5635-4347-45c0-8ecb-0dd5092ac07b

📥 Commits

Reviewing files that changed from the base of the PR and between 1561e4c and 177a654.

📒 Files selected for processing (1)
  • .github/workflows/pr-i18n.yaml

📝 Walkthrough

Walkthrough

The PR updates the i18n validation workflow to trigger on the ready_for_review pull request event in addition to existing events, and adds a condition to skip execution when the pull request is in draft status. All existing validation steps remain unchanged.

Changes

i18n Workflow Trigger Enhancement

Layer / File(s) Summary
Draft-aware ready-for-review trigger
.github/workflows/pr-i18n.yaml
Pull request trigger types expanded to include ready_for_review event alongside opened/synchronize/reopened. The i18n-check job is gated with a draft check condition to execute only for non-draft pull requests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • doodlum

Poem

🐰 A workflow springs to life anew,
When drafts are born, the checks stay true,
Ready for review, now shining bright,
i18n validated, all feels right!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding 'ready_for_review' trigger type to the i18n workflow, which aligns with the file modifications shown in the summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-i18n-audit

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 zizmor (1.25.2)
.github/workflows/pr-i18n.yaml

INFO zizmor: 🌈 zizmor v1.25.2
fatal: no audit was performed
invalid input: .github/workflows/pr-i18n.yaml

🔧 actionlint (1.7.12)
.github/workflows/pr-i18n.yaml

could not read ".github/workflows/pr-i18n.yaml": open .github/workflows/pr-i18n.yaml: no such file or directory

🔧 YAMLlint (1.38.0)
.github/workflows/pr-i18n.yaml

[Errno 2] No such file or directory: '.github/workflows/pr-i18n.yaml'

🔧 Checkov (3.2.530)
.github/workflows/pr-i18n.yaml

2026-06-03 14:50:22,720 [MainThread ] [ERROR] Template file not found: .github/workflows/pr-i18n.yaml
2026-06-03 14:50:22,741 [MainThread ] [ERROR] Template file not found: .github/workflows/pr-i18n.yaml
2026-06-03 14:50:22,796 [MainThread ] [ERROR] Template file not found: .github/workflows/pr-i18n.yaml
2026-06-03 14:50:22,795 [MainThread ] [ERROR] Failed to invoke function /usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner. with .github/workflows/pr-i18n.yaml
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 88, in func_wrapper
result = original_func(item)
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner.py", line 74, in
results = parallel_runner.run_function(lambda f: (f, self._parse_file(f)), files_to_load)
^^^^^^^

... [truncated 9097 characters] ...

ng: could not process file .github/workflows/pr-i18n.yaml
2026-06-03 14:50:22,993 [MainThread ] [ERROR] Exception traceback:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/main.py", line 647, in run
self.scan_reports = runner_registry.run(
^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/runner_registry.py", line 177, in run
for result in parallel_runner_results:
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 118, in _run_function_multiprocess_fork
raise v.internal_exception.with_traceback(v.internal_exception.traceback)
FileNotFoundError: [Errno 2] No such file or directory: '.github/workflows/pr-i18n.yaml'


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SkrubbySkrubInAShrub SkrubbySkrubInAShrub merged commit 7cbe43f into dev Jun 3, 2026
7 checks passed
@SkrubbySkrubInAShrub SkrubbySkrubInAShrub deleted the fix-i18n-audit branch June 3, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants