fix(vol-fog): add missing include

[jiayev]

Summary by CodeRabbit

• New Features
  • Exponential height fog rendering is now available as an optional feature.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR adds a conditional compilation block to the Sky shader that includes the exponential height fog shader implementation when the EXP_HEIGHT_FOG preprocessor flag is enabled. The include is placed in the pixel-shader section alongside other optional feature headers.

Changes

Exponential Height Fog Shader Integration

Layer / File(s)	Summary
Conditional exponential height fog include package/Shaders/Sky.hlsl	A #if defined(EXP_HEIGHT_FOG) block is added to conditionally include ExponentialHeightFog/ExponentialHeightFog.hlsli in the pixel-shader header section, allowing the fog feature to be compiled in or out based on the preprocessor flag.

Possibly related PRs

• community-shaders/skyrim-community-shaders#2301: Adds the exponential height fog shader implementation (ExponentialHeightFog.hlsli) with fog helpers and updated fog blending logic that this PR conditionally includes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A foggy mountain shader, conditionally blessed,
Sky now includes its misty, exponential dress,
When the flag is defined, the fog rolls in fine,
A simple four-line change makes the pixels align!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(vol-fog): add missing include' accurately describes the main change: adding a conditional include for ExponentialHeightFog.hlsli to the Sky.hlsl shader file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[coderabbitai]

🧹 Nitpick comments (1)

package/Shaders/Sky.hlsl (1)

196-198: ⚡ Quick win

Run hlslkit on the EXP_HEIGHT_FOG permutation before merge.

The conditional include placement looks correct, but please validate compile/resolve for this path (Line 196-Line 198) using hlslkit in targeted testing.
As per coding guidelines, "**/*.hlsl: Use hlslkit for shader validation and compilation during targeted development testing and before deployment".

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package/Shaders/Sky.hlsl` around lines 196 - 198, Run hlslkit against the
EXP_HEIGHT_FOG permutation for Sky.hlsl to validate that the conditional include
of ExponentialHeightFog/ExponentialHeightFog.hlsli resolves and compiles; if
hlslkit reports unresolved includes or compile errors, update the include path
or the permutation definitions (EXP_HEIGHT_FOG and any dependent defines) so the
file can be found and the shader compiles cleanly, and re-run hlslkit until the
permutation passes.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@package/Shaders/Sky.hlsl`:
- Around line 196-198: Run hlslkit against the EXP_HEIGHT_FOG permutation for
Sky.hlsl to validate that the conditional include of
ExponentialHeightFog/ExponentialHeightFog.hlsli resolves and compiles; if
hlslkit reports unresolved includes or compile errors, update the include path
or the permutation definitions (EXP_HEIGHT_FOG and any dependent defines) so the
file can be found and the shader compiles cleanly, and re-run hlslkit until the
permutation passes.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dfa83139-1e96-45ca-9113-66bf3f4a59e2

📥 Commits

Reviewing files that changed from the base of the PR and between 4d66c32 and 2900588.

📒 Files selected for processing (1)

• package/Shaders/Sky.hlsl