Skip to content

docs: update feature Nexus mod links#2358

Merged
alandtse merged 2 commits into
community-shaders:devfrom
brucenguyen:update-feature-mod-links
May 18, 2026
Merged

docs: update feature Nexus mod links#2358
alandtse merged 2 commits into
community-shaders:devfrom
brucenguyen:update-feature-mod-links

Conversation

@brucenguyen
Copy link
Copy Markdown
Contributor

@brucenguyen brucenguyen commented May 16, 2026

Was looking to remove the dummy Exponential Height Fog download link but realized that these haven't really been kept up to date.

Why do we need to maintain them?
These links are exposed if the feature is not installed. Practically speaking no one should have uninstalled core features but in the weird case that they delete the INI, they shouldn't need to see a link. Technically we can gate in the UI, but relying on a gate everywhere is a bit fragile (even if it should be regardless).

  • Add links for Sky Sync, Terrain Blending, Upscaling
  • Removes links for core features and dummy links

If we decide to split a feature out of core again then we'd need to re-add the link. If we prefer to keep the core links for some reason I can revert those.

Summary by CodeRabbit

  • Refactor
    • Standardized feature mod linking across the system. Multiple components were reorganized to consolidate how features connect to Nexus mod pages. Changes include enhanced mod linking capabilities for select features while others adopted streamlined approaches, creating more consistent and coordinated mod reference integration across the feature set.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

📝 Walkthrough

Walkthrough

Feature header declarations are refactored: many features remove their private MOD_ID constant and GetFeatureModLink() override; a small set of features (TerrainBlending, Upscaling, SkySync, ExponentialHeightFog) add or update MOD_ID and implement GetFeatureModLink() to return MakeNexusModURL(MOD_ID).

Changes

Mod-link Metadata Refactoring

Layer / File(s) Summary
Removing mod-link metadata from features
src/Features/ExtendedTranslucency.h, src/Features/GrassCollision.h, src/Features/GrassLighting.h, src/Features/InteriorSun.h, src/Features/InverseSquareLighting.h, src/Features/LightLimitFix.h, src/Features/ScreenSpaceShadows.h, src/Features/SubsurfaceScattering.h, src/Features/TerrainShadows.h, src/Features/WaterEffects.h
These headers have their private MOD_ID constants and/or GetFeatureModLink() overrides removed; access specifiers are adjusted so GetName() / GetShortName() remain public where shown.
Adding/updating mod-link metadata
src/Features/TerrainBlending.h, src/Features/Upscaling.h, src/Features/SkySync.h, src/Features/ExponentialHeightFog.h
These headers define a private MOD_ID constant and add or update GetFeatureModLink() to return MakeNexusModURL(MOD_ID).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • alandtse
  • doodlum
  • jiayev

Poem

🐰 Hopping through headers, I tidy the den,
MOD IDs moved, some gone, some back again.
Links stitched with care to MakeNexusModURL,
A warren of includes grows neat and full.
Happy hops — the code feels lighter than when!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 7.14% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ⚠️ Warning The title 'docs: update feature Nexus mod links' is vague and misleading. The PR makes substantive code changes (adding/removing MOD_ID constants and GetFeatureModLink() method overrides), not documentation-only updates. The 'docs:' prefix is incorrect. Update the title to accurately reflect that this is a code change, not documentation. Consider: 'chore: consolidate feature Nexus mod links' or 'refactor: manage feature mod links' to better describe the actual changes.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

No actionable suggestions for changed features.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 16, 2026

✅ A pre-release build is available for this PR:
Download

@alandtse
Copy link
Copy Markdown
Collaborator

Feature authors may put in a link to a page they are working on. We shouldn't strip them out.

@alandtse
Copy link
Copy Markdown
Collaborator

If something is CORE, then I agree we can remove them since it's unlikely a page will be used.

@brucenguyen
Copy link
Copy Markdown
Contributor Author

brucenguyen commented May 17, 2026

Feature authors may put in a link to a page they are working on. We shouldn't strip them out.

Only removed links were for core and Exponential Height Fog (which was a dummy link). The author can add in the real link when ready. Apologies for misnomer in the PR description.

Feel free to validate.

@brucenguyen
Copy link
Copy Markdown
Contributor Author

Claude summary:

Sky Sync — added link (153543); was missing from menu
Terrain Blending — added link (157076); was missing from menu
Upscaling — added link (156952); was missing from menu
Exponential Height Fog — removed dummy 999999; not a real mod ID
Grass Collision — stripped link; core, not published standalone
Grass Lighting — stripped link; core, not published standalone
Water Effects — stripped link; core, not published standalone
Terrain Shadows — stripped link; core, not published standalone
Subsurface Scattering — stripped link; core, not published standalone
Screen Space Shadows — stripped link; core, not published standalone
Light Limit Fix — stripped link; core, not published standalone
Extended Translucency — stripped link; core, not published standalone
Interior Sun — removed dead MOD_ID constant; never referenced
Inverse Square Lighting — removed dead MOD_ID constant; never referenced

@brucenguyen
Copy link
Copy Markdown
Contributor Author

Interior Sun and ISL are both marked core.

@SkrubbySkrubInAShrub
Copy link
Copy Markdown
Collaborator

Exponential height fog is 180146

@brucenguyen
Copy link
Copy Markdown
Contributor Author

Exponential height fog is 180146

ty king, updated.

I do think that did warrant a "request change" but luckily no one merged.

@SkrubbySkrubInAShrub
Copy link
Copy Markdown
Collaborator

Exponential height fog is 180146

ty king, updated.

I do think that did warrant a "request change" but luckily no one merged.

I don't want to mergeblock when it is resolved.

@alandtse alandtse changed the title chore: update feature Nexus mod links docs: update feature Nexus mod links May 18, 2026
@alandtse alandtse merged commit 56a3526 into community-shaders:dev May 18, 2026
14 checks passed
@alandtse
Copy link
Copy Markdown
Collaborator

Merge block is appropriate. If absolutely necessary, we can override or directly edit. Otherwise it'll be forgotten given the amount of comment spam we get from coderabbit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants