docs: update feature Nexus mod links#2358
Conversation
📝 WalkthroughWalkthroughFeature header declarations are refactored: many features remove their private ChangesMod-link Metadata Refactoring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
No actionable suggestions for changed features. |
|
✅ A pre-release build is available for this PR: |
|
Feature authors may put in a link to a page they are working on. We shouldn't strip them out. |
|
If something is CORE, then I agree we can remove them since it's unlikely a page will be used. |
Only removed links were for core and Exponential Height Fog (which was a dummy link). The author can add in the real link when ready. Apologies for misnomer in the PR description. Feel free to validate. |
|
Claude summary: Sky Sync — added link (153543); was missing from menu |
|
Interior Sun and ISL are both marked core. |
|
Exponential height fog is 180146 |
ty king, updated. I do think that did warrant a "request change" but luckily no one merged. |
I don't want to mergeblock when it is resolved. |
|
Merge block is appropriate. If absolutely necessary, we can override or directly edit. Otherwise it'll be forgotten given the amount of comment spam we get from coderabbit. |
Was looking to remove the dummy Exponential Height Fog download link but realized that these haven't really been kept up to date.
Why do we need to maintain them?
These links are exposed if the feature is not installed. Practically speaking no one should have uninstalled core features but in the weird case that they delete the INI, they shouldn't need to see a link. Technically we can gate in the UI, but relying on a gate everywhere is a bit fragile (even if it should be regardless).
If we decide to split a feature out of core again then we'd need to re-add the link. If we prefer to keep the core links for some reason I can revert those.
Summary by CodeRabbit