Skip to content

fix(ishdr): gate bloom for legacy weather mods #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doodlum merged 2 commits into from
May 8, 2026
Merged

fix(ishdr): gate bloom for legacy weather mods #2297

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
630e7c3
fix(ishdr): gate bloom expression for Reinhard path to prevent highli…
SkrubbySkrubInAShrub May 8, 2026
131756e
chore: add comment, remove documentation
SkrubbySkrubInAShrub May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion package/Shaders/ISHDR.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,12 @@ PS_OUTPUT main(PS_INPUT input)
float mappedMax = GetTonemapFactorReinhard(maxCol, isHDR).x;
float3 compressedHuePreserving = inputColor * mappedMax / maxCol;
blendedColor = compressedHuePreserving;
blendedColor += saturate(Param.x - (1.0 - exp2(-blendedColor))) * bloomColor;
// SDR uses a hard cutoff (Param.x - blendedColor) so legacy weather mods that tuned
// bloom intensity against this shoulder don't get blown-out highlights. HDR keeps the
// soft-saturation form (1 - exp2(-x)) which bleeds bloom into specular peaks intentionally.
float3 bloomMask = isHDR ? saturate(Param.x - (1.0 - exp2(-blendedColor)))
: saturate(Param.x - blendedColor);
blendedColor += bloomMask * bloomColor;
}

float blendedLuminance = Color::RGBToLuminance(blendedColor);
Expand Down
Loading