From f2d5623de06d985acdb1cc3c87e19f92ac5d1d9a Mon Sep 17 00:00:00 2001 From: Alan Tse Date: Sun, 3 May 2026 02:09:16 -0700 Subject: [PATCH] ci: bump actions to node24 to clear deprecation warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GitHub Actions is forcing node20 actions to node24 by default on 2026-06-02 and removing node20 from the runner on 2026-09-16. Three actions in setup-build-environment were still on node20: - ilammy/msvc-dev-cmd@v1 → TheMrMilchmann/setup-msvc-dev@v4.0.0 - lukka/run-vcpkg@v11.5 → lukka/run-vcpkg@v11.6 - actions/cache@v4 → actions/cache@v5 Notes on the MSVC swap: TheMrMilchmann/setup-msvc-dev has no `vsversion` input. The preceding step installs only VS Build Tools 2026, so the action's default detection picks it up. `arch: x64` input is preserved. Co-Authored-By: Claude Sonnet 4.6 --- .github/actions/setup-build-environment/action.yaml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/actions/setup-build-environment/action.yaml b/.github/actions/setup-build-environment/action.yaml index b7cc330519..ef1092a800 100644 --- a/.github/actions/setup-build-environment/action.yaml +++ b/.github/actions/setup-build-environment/action.yaml @@ -46,10 +46,13 @@ runs: Remove-Item $installerPath -ErrorAction SilentlyContinue - name: Setup MSVC environment - uses: ilammy/msvc-dev-cmd@v1 + # Swapped from ilammy/msvc-dev-cmd@v1 (node20, deprecated) to + # TheMrMilchmann/setup-msvc-dev@v4 (node24). The new action has no + # `vsversion` input — the prior step installs only VS Build Tools + # 2026, so default detection picks it up. + uses: TheMrMilchmann/setup-msvc-dev@v4.0.0 with: arch: x64 - vsversion: "18.0" - name: Get MSVC version id: msvc_version @@ -85,12 +88,12 @@ runs: Remove-Item "dummy.cpp" -ErrorAction SilentlyContinue - name: Setup vcpkg - uses: lukka/run-vcpkg@v11.5 + uses: lukka/run-vcpkg@v11.6 with: vcpkgJsonGlob: vcpkg.json - name: Cache CMake build output - uses: actions/cache@v4 + uses: actions/cache@v5 with: path: ${{ inputs.build-dir }} key: ${{ runner.os }}-cmake-msvc-${{ steps.msvc_version.outputs.version }}-${{ inputs.cache-key-suffix }}-${{ github.event.inputs.cache-key-suffix || 'default' }}-${{ hashFiles('.gitmodules', 'extern/**', 'CMakePresets.json', 'vcpkg.json', 'vcpkg-configuration.json') }}