Skip to content

fix(Exponential-fog): disable by default to prevent unintended visuals#2131

Merged
davo0411 merged 2 commits into
community-shaders:devfrom
SkrubbySkrubInAShrub:expfog-off
Apr 16, 2026
Merged

fix(Exponential-fog): disable by default to prevent unintended visuals#2131
davo0411 merged 2 commits into
community-shaders:devfrom
SkrubbySkrubInAShrub:expfog-off

Conversation

@SkrubbySkrubInAShrub
Copy link
Copy Markdown
Collaborator

@SkrubbySkrubInAShrub SkrubbySkrubInAShrub commented Apr 16, 2026

Summary by CodeRabbit

  • Chores
    • Exponential height fog feature is now disabled by default instead of enabled.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9c5ec922-ff65-41d8-9fdd-b76908cbfaf0

📥 Commits

Reviewing files that changed from the base of the PR and between 4b15683 and 9b1416d.

📒 Files selected for processing (1)
  • src/Features/ExponentialHeightFog.h

📝 Walkthrough

Walkthrough

The default value of ExponentialHeightFog::Settings::enabled was changed from 1 to 0 in the header file, making the feature disabled by default unless explicitly enabled during configuration or initialization.

Changes

Cohort / File(s) Summary
Exponential Height Fog Configuration
src/Features/ExponentialHeightFog.h
Changed the enabled field default value from 1 to 0, altering the initial state of the feature to disabled.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Suggested reviewers

  • doodlum

Poem

🐰✨ A single tweak, so small and neat,
Default disabled, now complete!
No fog at dawn without a say,
Enable when you need the haze to play.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: disabling the ExponentialHeightFog feature by default to prevent unintended visuals, which directly matches the changeset modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

No actionable suggestions for changed features.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

✅ A pre-release build is available for this PR:
Download

@davo0411 davo0411 merged commit 4300933 into community-shaders:dev Apr 16, 2026
15 checks passed
YtzyFvra pushed a commit to YtzyFvra/skyrim-community-shaders that referenced this pull request Apr 19, 2026
Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants