From e798a989bb7588b563c55c40ffdbb465c2735814 Mon Sep 17 00:00:00 2001 From: doodlum <15017472+doodlum@users.noreply.github.com> Date: Mon, 5 Jan 2026 17:42:58 +0000 Subject: [PATCH 1/2] chore: move some features to core --- features/Extended Translucency/CORE | 0 features/Interior Sun/CORE | 0 features/Inverse Square Lighting/CORE | 0 features/Terrain Shadows - Heightmaps/CORE | 0 features/Terrain Shadows/CORE | 0 features/Water Effects/CORE | 0 src/Features/ExtendedTranslucency.h | 2 ++ src/Features/InteriorSun.h | 2 ++ src/Features/InverseSquareLighting.h | 1 + src/Features/TerrainShadows.h | 1 + src/Features/WaterEffects.h | 1 + 11 files changed, 7 insertions(+) create mode 100644 features/Extended Translucency/CORE create mode 100644 features/Interior Sun/CORE create mode 100644 features/Inverse Square Lighting/CORE create mode 100644 features/Terrain Shadows - Heightmaps/CORE create mode 100644 features/Terrain Shadows/CORE create mode 100644 features/Water Effects/CORE diff --git a/features/Extended Translucency/CORE b/features/Extended Translucency/CORE new file mode 100644 index 0000000000..e69de29bb2 diff --git a/features/Interior Sun/CORE b/features/Interior Sun/CORE new file mode 100644 index 0000000000..e69de29bb2 diff --git a/features/Inverse Square Lighting/CORE b/features/Inverse Square Lighting/CORE new file mode 100644 index 0000000000..e69de29bb2 diff --git a/features/Terrain Shadows - Heightmaps/CORE b/features/Terrain Shadows - Heightmaps/CORE new file mode 100644 index 0000000000..e69de29bb2 diff --git a/features/Terrain Shadows/CORE b/features/Terrain Shadows/CORE new file mode 100644 index 0000000000..e69de29bb2 diff --git a/features/Water Effects/CORE b/features/Water Effects/CORE new file mode 100644 index 0000000000..e69de29bb2 diff --git a/src/Features/ExtendedTranslucency.h b/src/Features/ExtendedTranslucency.h index 369d9d4ae8..e0a4161fe6 100644 --- a/src/Features/ExtendedTranslucency.h +++ b/src/Features/ExtendedTranslucency.h @@ -60,4 +60,6 @@ struct ExtendedTranslucency final : Feature const PerFrame& GetCommonBufferData() { return settings; } static const RE::BSFixedString NiExtraDataName_AnisotropicAlphaMaterial; + + virtual bool IsCore() const override { return true; }; }; diff --git a/src/Features/InteriorSun.h b/src/Features/InteriorSun.h index 353c962da9..c9312e4d00 100644 --- a/src/Features/InteriorSun.h +++ b/src/Features/InteriorSun.h @@ -72,6 +72,7 @@ struct InteriorSun : Feature } static bool IsInteriorWithSun(const RE::TESObjectCELL* cell); + virtual bool IsCore() const override { return true; }; private: enum class CellFlagExt : uint16_t @@ -102,4 +103,5 @@ struct InteriorSun : Feature void PopulateReplacementJobArrays(RE::TESObjectCELL* cell, const RE::NiPointer& portalGraph, const RE::BSShadowDirectionalLight* dirLight, RE::BSTArray>>& jobArrays); static void SetShadowDistance(bool inInterior); + }; \ No newline at end of file diff --git a/src/Features/InverseSquareLighting.h b/src/Features/InverseSquareLighting.h index bc73c1a836..841a62c8b8 100644 --- a/src/Features/InverseSquareLighting.h +++ b/src/Features/InverseSquareLighting.h @@ -56,6 +56,7 @@ struct InverseSquareLighting : Feature static float thunk(RE::BSLight* bsLight, RE::NiPoint3* targetPosition, RE::NiLight* refLight); static inline REL::Relocation func; }; + virtual bool IsCore() const override { return true; }; private: LightEditor editor = LightEditor(); diff --git a/src/Features/TerrainShadows.h b/src/Features/TerrainShadows.h index c5add44144..cce9c69035 100644 --- a/src/Features/TerrainShadows.h +++ b/src/Features/TerrainShadows.h @@ -96,4 +96,5 @@ struct TerrainShadows : public Feature virtual inline void RestoreDefaultSettings() override { settings = {}; } virtual void ClearShaderCache() override; virtual bool SupportsVR() override { return true; }; + virtual bool IsCore() const override { return true; }; }; \ No newline at end of file diff --git a/src/Features/WaterEffects.h b/src/Features/WaterEffects.h index 2c71b3a7b3..afced18233 100644 --- a/src/Features/WaterEffects.h +++ b/src/Features/WaterEffects.h @@ -35,4 +35,5 @@ struct WaterEffects : Feature virtual void Prepass() override; virtual bool SupportsVR() override { return true; }; + virtual bool IsCore() const override { return true; }; }; From 64ce69a82b9e5ed0d402cbd1e93b12460cd9f98f Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 5 Jan 2026 17:43:38 +0000 Subject: [PATCH 2/2] =?UTF-8?q?style:=20=F0=9F=8E=A8=20apply=20pre-commit.?= =?UTF-8?q?ci=20formatting?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details. --- src/Features/ExtendedTranslucency.h | 2 +- src/Features/InteriorSun.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Features/ExtendedTranslucency.h b/src/Features/ExtendedTranslucency.h index e0a4161fe6..d61348a3ca 100644 --- a/src/Features/ExtendedTranslucency.h +++ b/src/Features/ExtendedTranslucency.h @@ -60,6 +60,6 @@ struct ExtendedTranslucency final : Feature const PerFrame& GetCommonBufferData() { return settings; } static const RE::BSFixedString NiExtraDataName_AnisotropicAlphaMaterial; - + virtual bool IsCore() const override { return true; }; }; diff --git a/src/Features/InteriorSun.h b/src/Features/InteriorSun.h index c9312e4d00..d2abc00ab7 100644 --- a/src/Features/InteriorSun.h +++ b/src/Features/InteriorSun.h @@ -103,5 +103,4 @@ struct InteriorSun : Feature void PopulateReplacementJobArrays(RE::TESObjectCELL* cell, const RE::NiPointer& portalGraph, const RE::BSShadowDirectionalLight* dirLight, RE::BSTArray>>& jobArrays); static void SetShadowDistance(bool inInterior); - }; \ No newline at end of file