From 5ad35fd534f074f457e3853d06d3da8e888d0909 Mon Sep 17 00:00:00 2001 From: David Kehoe Date: Sun, 21 Dec 2025 14:08:03 -0800 Subject: [PATCH 1/5] fixes --- features/Water Effects/CORE | 0 src/Features/WaterEffects.cpp | 5 +++++ src/Features/WaterEffects.h | 8 +++++--- 3 files changed, 10 insertions(+), 3 deletions(-) create mode 100644 features/Water Effects/CORE diff --git a/features/Water Effects/CORE b/features/Water Effects/CORE new file mode 100644 index 0000000000..e69de29bb2 diff --git a/src/Features/WaterEffects.cpp b/src/Features/WaterEffects.cpp index 32b80d6ccb..950210ae63 100644 --- a/src/Features/WaterEffects.cpp +++ b/src/Features/WaterEffects.cpp @@ -21,3 +21,8 @@ bool WaterEffects::HasShaderDefine(RE::BSShader::Type) { return true; } + +void WaterEffects::DrawSettings() +{ + ImGui::Text("Parallax requires valid alpha channel data in water .dds textures (regular and flow map variants)."); +} diff --git a/src/Features/WaterEffects.h b/src/Features/WaterEffects.h index 2c71b3a7b3..1d597bd051 100644 --- a/src/Features/WaterEffects.h +++ b/src/Features/WaterEffects.h @@ -18,8 +18,7 @@ struct WaterEffects : Feature virtual std::pair> GetFeatureSummary() override { return { - "Water Effects enhances water rendering with realistic caustics and underwater lighting effects.\n" - "This feature adds dynamic light patterns and improved water visual quality.", + "This feature implements basic water effects, including parallax, flow map parallax, caustics and lighting tweaks.", { "Realistic water caustics", "Enhanced underwater lighting", "Dynamic light patterns on water surfaces", @@ -28,6 +27,8 @@ struct WaterEffects : Feature }; } + virtual bool IsCore() const override { return true; } + bool HasShaderDefine(RE::BSShader::Type shaderType) override; virtual void SetupResources() override; @@ -35,4 +36,5 @@ struct WaterEffects : Feature virtual void Prepass() override; virtual bool SupportsVR() override { return true; }; -}; + + virtual void DrawSettings() override; From de68b4007054e860852d6fea1987d02d6350ffc6 Mon Sep 17 00:00:00 2001 From: David Kehoe Date: Mon, 29 Dec 2025 17:48:31 -0800 Subject: [PATCH 2/5] remove broken description --- src/Features/WaterEffects.cpp | 7 +------ src/Features/WaterEffects.h | 2 -- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/Features/WaterEffects.cpp b/src/Features/WaterEffects.cpp index 950210ae63..e9665bff88 100644 --- a/src/Features/WaterEffects.cpp +++ b/src/Features/WaterEffects.cpp @@ -20,9 +20,4 @@ void WaterEffects::Prepass() bool WaterEffects::HasShaderDefine(RE::BSShader::Type) { return true; -} - -void WaterEffects::DrawSettings() -{ - ImGui::Text("Parallax requires valid alpha channel data in water .dds textures (regular and flow map variants)."); -} +} \ No newline at end of file diff --git a/src/Features/WaterEffects.h b/src/Features/WaterEffects.h index 1d597bd051..9019b6457d 100644 --- a/src/Features/WaterEffects.h +++ b/src/Features/WaterEffects.h @@ -36,5 +36,3 @@ struct WaterEffects : Feature virtual void Prepass() override; virtual bool SupportsVR() override { return true; }; - - virtual void DrawSettings() override; From b6e336440b3bd564c7d9253d49288e4a044fe4bc Mon Sep 17 00:00:00 2001 From: davo0411 Date: Wed, 31 Dec 2025 18:22:33 +1000 Subject: [PATCH 3/5] Update src/Features/WaterEffects.cpp Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- src/Features/WaterEffects.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Features/WaterEffects.cpp b/src/Features/WaterEffects.cpp index e9665bff88..6ab7ac00ea 100644 --- a/src/Features/WaterEffects.cpp +++ b/src/Features/WaterEffects.cpp @@ -17,6 +17,9 @@ void WaterEffects::Prepass() context->PSSetShaderResources(65, 1, &srv); } +bool WaterEffects::HasShaderDefine(RE::BSShader::Type) +{ + return true; bool WaterEffects::HasShaderDefine(RE::BSShader::Type) { return true; From be4dfe9697cebf10237826a716baad368f284c5d Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed, 31 Dec 2025 08:22:53 +0000 Subject: [PATCH 4/5] =?UTF-8?q?style:=20=F0=9F=8E=A8=20apply=20pre-commit.?= =?UTF-8?q?ci=20formatting?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details. --- src/Features/WaterEffects.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Features/WaterEffects.cpp b/src/Features/WaterEffects.cpp index 6ab7ac00ea..ab04f40ea5 100644 --- a/src/Features/WaterEffects.cpp +++ b/src/Features/WaterEffects.cpp @@ -20,7 +20,7 @@ void WaterEffects::Prepass() bool WaterEffects::HasShaderDefine(RE::BSShader::Type) { return true; -bool WaterEffects::HasShaderDefine(RE::BSShader::Type) -{ - return true; -} \ No newline at end of file + bool WaterEffects::HasShaderDefine(RE::BSShader::Type) + { + return true; + } \ No newline at end of file From d954816beaf1ef205336520306571508f8ae7889 Mon Sep 17 00:00:00 2001 From: David Kehoe Date: Sun, 4 Jan 2026 00:09:57 -0500 Subject: [PATCH 5/5] fix: file corruption --- src/Features/WaterEffects.cpp | 5 +---- src/Features/WaterEffects.h | 3 ++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/Features/WaterEffects.cpp b/src/Features/WaterEffects.cpp index ab04f40ea5..e9665bff88 100644 --- a/src/Features/WaterEffects.cpp +++ b/src/Features/WaterEffects.cpp @@ -20,7 +20,4 @@ void WaterEffects::Prepass() bool WaterEffects::HasShaderDefine(RE::BSShader::Type) { return true; - bool WaterEffects::HasShaderDefine(RE::BSShader::Type) - { - return true; - } \ No newline at end of file +} \ No newline at end of file diff --git a/src/Features/WaterEffects.h b/src/Features/WaterEffects.h index 9019b6457d..80441c28d9 100644 --- a/src/Features/WaterEffects.h +++ b/src/Features/WaterEffects.h @@ -35,4 +35,5 @@ struct WaterEffects : Feature virtual void Prepass() override; - virtual bool SupportsVR() override { return true; }; + virtual bool SupportsVR() override { return true; } +};