From c23e9738e8520fed549a0c537ab07a0e9bf4cbcc Mon Sep 17 00:00:00 2001 From: Bruce Nguyen Date: Tue, 2 Dec 2025 09:56:10 -0500 Subject: [PATCH 1/2] feat(UI): move light limit visualization into debug section --- src/Features/LightLimitFix.cpp | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/Features/LightLimitFix.cpp b/src/Features/LightLimitFix.cpp index 40aa95dfd8..67693024a2 100644 --- a/src/Features/LightLimitFix.cpp +++ b/src/Features/LightLimitFix.cpp @@ -17,7 +17,16 @@ void LightLimitFix::DrawSettings() { auto shaderCache = globals::shaderCache; - if (ImGui::TreeNodeEx("Light Limit Visualization", ImGuiTreeNodeFlags_DefaultOpen)) { + if (ImGui::TreeNodeEx("Statistics", ImGuiTreeNodeFlags_DefaultOpen)) { + ImGui::Text(std::format("Clustered Light Count : {}", lightCount).c_str()); + + ImGui::TreePop(); + } + + /////////////////////////////// + ImGui::SeparatorText("Debug"); + + if (ImGui::TreeNode("Light Limit Visualization")) { ImGui::Checkbox("Enable Lights Visualisation", &settings.EnableLightsVisualisation); if (auto _tt = Util::HoverTooltipWrapper()) { ImGui::Text("Enables visualization of the light limit\n"); @@ -43,12 +52,6 @@ void LightLimitFix::DrawSettings() ImGui::TreePop(); } - - if (ImGui::TreeNodeEx("Statistics", ImGuiTreeNodeFlags_DefaultOpen)) { - ImGui::Text(std::format("Clustered Light Count : {}", lightCount).c_str()); - - ImGui::TreePop(); - } } LightLimitFix::PerFrame LightLimitFix::GetCommonBufferData() @@ -563,4 +566,4 @@ void LightLimitFix::Hooks::BSWaterShader_SetupGeometry::thunk(RE::BSShader* This auto& singleton = globals::features::lightLimitFix; singleton.BSLightingShader_SetupGeometry_Before(Pass); singleton.BSLightingShader_SetupGeometry_After(Pass); -}; \ No newline at end of file +}; From 3733fb8e5a8b9f440cdc53b20efa8f42007c5f63 Mon Sep 17 00:00:00 2001 From: Bruce Nguyen Date: Tue, 2 Dec 2025 16:07:42 -0500 Subject: [PATCH 2/2] fix: make light visualisation ephemeral --- src/Features/LightLimitFix.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Features/LightLimitFix.cpp b/src/Features/LightLimitFix.cpp index 67693024a2..23c7f083aa 100644 --- a/src/Features/LightLimitFix.cpp +++ b/src/Features/LightLimitFix.cpp @@ -10,7 +10,6 @@ static constexpr uint MAX_LIGHTS = 1024; NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE_WITH_DEFAULT( LightLimitFix::Settings, EnableContactShadows, - EnableLightsVisualisation, LightsVisualisationMode) void LightLimitFix::DrawSettings()