fix: interior dynamic cubemap for non-deferred

[jiayev]

Summary by CodeRabbit

• Bug Fixes
  • Improved interior lighting by ensuring specular irradiance is correctly included in dynamic cubemaps.

[coderabbitai]

Walkthrough

An accumulation step was added to the GetDynamicCubemapSpecularIrradiance function, modifying the return value of finalIrradiance in the case where SharedData::InInterior is true. The function now adds specularIrradiance to finalIrradiance before returning it.

Changes

File(s)	Change Summary
features/Dynamic Cubemaps/Shaders/DynamicCubemaps/DynamicCubemaps.hlsli	Added accumulation of specularIrradiance to finalIrradiance in the interior lighting conditional

Poem

In the world of cubemaps, a shimmer anew,
Specular light joins the final view.
Indoors now glow with radiant might,
As irradiance blends, making things bright.
A hop and a blend, the shader’s delight!
🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ae5bb5 and 1942a28.

📒 Files selected for processing (1)

• features/Dynamic Cubemaps/Shaders/DynamicCubemaps/DynamicCubemaps.hlsli (1 hunks)

🔇 Additional comments (1)

features/Dynamic Cubemaps/Shaders/DynamicCubemaps/DynamicCubemaps.hlsli (1)

50-50: LGTM! Critical fix for interior specular reflections.

This change correctly accumulates the sampled specular irradiance to finalIrradiance in the interior case, fixing a bug where interior specular reflections would be disabled. The fix brings consistency with the non-interior case (line 73) and the corresponding logic in GetDynamicCubemap (line 107).

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Using provided base ref: 8ae5bb5
Using base ref: 8ae5bb5
Base commit date: 2025-07-17T11:25:25-07:00 (Thursday, July 17, 2025 11:25 AM)
No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download