From 910b966d2658eff84285ffeae8380b57907cefe9 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 15 Jul 2025 07:26:49 +0000 Subject: [PATCH 1/3] Initial plan From 23c81e5d17a89fbb3ab03d04bc5452e9809df2aa Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 15 Jul 2025 07:30:51 +0000 Subject: [PATCH 2/3] Add Extended Translucency to Lighting category Co-authored-by: alandtse <7086117+alandtse@users.noreply.github.com> --- src/Features/ExtendedTranslucency.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Features/ExtendedTranslucency.h b/src/Features/ExtendedTranslucency.h index bc78d25a44..7e9221c0d6 100644 --- a/src/Features/ExtendedTranslucency.h +++ b/src/Features/ExtendedTranslucency.h @@ -10,6 +10,7 @@ struct ExtendedTranslucency final : Feature virtual inline std::string GetName() override { return "Extended Translucency"; } virtual inline std::string GetShortName() override { return "ExtendedTranslucency"; } virtual inline std::string_view GetShaderDefineName() override { return "EXTENDED_TRANSLUCENCY"; } + virtual std::string_view GetCategory() const override { return "Lighting"; } virtual bool HasShaderDefine(RE::BSShader::Type shaderType) override { return RE::BSShader::Type::Lighting == shaderType; }; virtual void PostPostLoad() override; virtual void DrawSettings() override; From 474fc06a6efba4d6650b03d187b38eb4cf4deb1e Mon Sep 17 00:00:00 2001 From: Alan Tse Date: Tue, 15 Jul 2025 01:09:43 -0700 Subject: [PATCH 3/3] refactor: add inline Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- src/Features/ExtendedTranslucency.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Features/ExtendedTranslucency.h b/src/Features/ExtendedTranslucency.h index 7e9221c0d6..a8615d7d19 100644 --- a/src/Features/ExtendedTranslucency.h +++ b/src/Features/ExtendedTranslucency.h @@ -10,7 +10,7 @@ struct ExtendedTranslucency final : Feature virtual inline std::string GetName() override { return "Extended Translucency"; } virtual inline std::string GetShortName() override { return "ExtendedTranslucency"; } virtual inline std::string_view GetShaderDefineName() override { return "EXTENDED_TRANSLUCENCY"; } - virtual std::string_view GetCategory() const override { return "Lighting"; } + virtual inline std::string_view GetCategory() const override { return "Lighting"; } virtual bool HasShaderDefine(RE::BSShader::Type shaderType) override { return RE::BSShader::Type::Lighting == shaderType; }; virtual void PostPostLoad() override; virtual void DrawSettings() override;