fix(menu): prioritize obsolete feature detection over restart by davo0411 · Pull Request #1205 · community-shaders/skyrim-community-shaders

davo0411 · 2025-06-26T08:32:28Z

Fixed obsolete feature UI logic that incorrectly displayed "This feature will be available after restart" for removed features like TerrainBlending. Now prioritizes obsolete feature detection before checking INI file existence, ensuring proper error messages are shown. Also prevents duplicate error display by excluding obsolete features from the Error section since DrawUnloadedUI() already handles their messaging appropriately.

Summary by CodeRabbit

New Features
- Improved menu UI to clearly indicate when features are obsolete, including detailed error information for such features.
Bug Fixes
- Suppressed error messages for failed loads of obsolete features to reduce unnecessary alerts.
Refactor
- Updated the display logic so that obsolete features are hidden from the "Unloaded Features" menu section for regular users, but remain visible in developer mode.

Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details.

coderabbitai · 2025-06-26T08:33:17Z

Walkthrough

The changes update the menu UI rendering logic to explicitly handle obsolete features. When drawing settings for unloaded features, the code now checks for obsolescence and adjusts the UI and error message display accordingly. Obsolete features are hidden from normal users but remain visible in developer mode.

Changes

File(s)	Change Summary
src/Menu.cpp	Added explicit checks for obsolete features in settings UI rendering, updated error/message display, and adjusted feature filtering for developer mode.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Menu
    participant Feature
    participant FeatureIssues

    User->>Menu: Open Settings
    Menu->>Feature: IsLoaded?
    alt Feature not loaded
        Menu->>FeatureIssues: IsObsoleteFeature?
        alt Obsolete
            Menu->>Feature: DrawUnloadedUI(errorInfo)
        else Not obsolete
            Menu->>Feature: HasIniFile?
            alt INI exists
                Menu->>Feature: ShowPendingRestartMsg()
            else
                Menu->>Feature: DrawUnloadedUI(errorInfo)
            end
        end
    else Feature loaded
        Menu->>Feature: DrawSettingsUI()
    end

Possibly related PRs

fix(ui): distinguish missing vs pending features #1188: Extends UI handling for obsolete features and uses Feature::DrawUnloadedUI() in menu rendering.
fix: fix detection of deleted obsolete features #1157: Refactors feature loading to improve detection and handling of obsolete features.
feat(ui): add feature summary tooltips and enhanced unloaded UI #1134: Enhances DrawUnloadedUI() and adds GetFeatureSummary() for detailed UI/tooltips in menu rendering.

Suggested reviewers

doodlum

Poem

In the warren of menus, a change hops through,
Obsolete features now hidden from view.
Unless you’re a dev, with a keen rabbit’s eye,
The old and the dusty just pass you by.
🐇✨
Settings now clearer, with less to confuse,
This bunny approves—good work, clever crews!

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b60270e and a36d36e.

📒 Files selected for processing (1)

src/Menu.cpp (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/Menu.cpp (3)

src/FeatureIssues.cpp (2)

IsObsoleteFeature (714-718)

IsObsoleteFeature (714-714)

src/Utils/FileSystem.cpp (2)

GetFeatureIniPath (39-42)

GetFeatureIniPath (39-39)

src/Utils/UI.cpp (2)

HoverTooltipWrapper (19-26)

HoverTooltipWrapper (28-34)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: Build plugin and addons
GitHub Check: Feature Version Audit (PR)

🔇 Additional comments (4)

src/Menu.cpp (4)

840-844: Excellent fix! Correctly prioritizes obsolete feature detection.

This change properly addresses the core issue by checking for obsolete features before evaluating INI file existence. The logic flow now ensures that obsolete features (like TerrainBlending) will always display appropriate error information via DrawUnloadedUI() rather than incorrectly showing restart messages.

844-860: Good restructuring of download link logic.

Moving the download link code inside the conditional block for non-obsolete features is correct. This ensures that obsolete features won't display download links (since they're no longer available), while preserving the functionality for legitimately missing features.

865-866: Smart elimination of duplicate error messages.

Adding the obsolete feature check to the error message condition prevents redundant error display. Since DrawUnloadedUI() already handles appropriate messaging for obsolete features, excluding them from the separate "Error" section avoids confusion and improves UI clarity.

1070-1070: Excellent user experience enhancement.

The filter modification appropriately hides obsolete features from regular users in the "Unloaded Features" section while preserving visibility for developers. This improves the user experience by reducing clutter of unusable features while maintaining debugging capabilities.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-06-26T08:34:07Z

Using provided base ref: b60270e
Using base ref: b60270e
Base commit date: 2025-06-25T23:51:08-07:00 (Wednesday, June 25, 2025 11:51 PM)
No actionable suggestions for changed features.

alandtse · 2025-06-26T08:34:48Z

@coderabbitai please provide a conventional commit within char limits that covers the changes

coderabbitai · 2025-06-26T08:35:16Z

Tip

For best results, initiate chat on the files or code changes.

@alandtse Here's a conventional commit message that covers the changes:

fix(menu): prioritize obsolete feature detection over restart messages

This 65-character commit message captures the core fix. If you need a more detailed body, it could be:

fix(menu): prioritize obsolete feature detection over restart messages

- Check for obsolete features before INI file existence
- Hide obsolete features from unloaded features list for regular users
- Prevent duplicate error messages for obsolete features

github-actions · 2025-06-26T08:49:40Z

✅ A pre-release build is available for this PR:
Download

…ity-shaders#1205) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

davo0411 and others added 3 commits June 26, 2025 18:01

Update Menu.cpp

defa42b

Update Menu.cpp

c71cde4

style: 🎨 apply pre-commit.ci formatting

a36d36e

Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details.

alandtse changed the title ~~fix: prioritize obsolete feature detection over restart msg, hide obsolete features from unloaded features~~ fix(menu): prioritize obsolete feature detection over restart Jun 26, 2025

alandtse approved these changes Jun 26, 2025

View reviewed changes

alandtse merged commit 8afbaa1 into community-shaders:dev Jun 26, 2025
17 checks passed

davo0411 deleted the checking-error branch June 30, 2025 11:59

coderabbitai Bot mentioned this pull request Apr 8, 2026

feat: detect obsolete shader mods with no feature INIs #2074

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(menu): prioritize obsolete feature detection over restart#1205

fix(menu): prioritize obsolete feature detection over restart#1205
alandtse merged 3 commits into
community-shaders:devfrom
davo0411:checking-error

davo0411 commented Jun 26, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 26, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

github-actions Bot commented Jun 26, 2025

Uh oh!

alandtse commented Jun 26, 2025

Uh oh!

coderabbitai Bot commented Jun 26, 2025

Uh oh!

github-actions Bot commented Jun 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

davo0411 commented Jun 26, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

github-actions Bot commented Jun 26, 2025

Uh oh!

alandtse commented Jun 26, 2025

Uh oh!

coderabbitai Bot commented Jun 26, 2025

Uh oh!

github-actions Bot commented Jun 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

davo0411 commented Jun 26, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 26, 2025 •

edited

Loading