Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme disclaimer of nextjs static only bundle #3

Open
davidcheung opened this issue Apr 22, 2022 · 2 comments
Open

Readme disclaimer of nextjs static only bundle #3

davidcheung opened this issue Apr 22, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@davidcheung
Copy link
Contributor

davidcheung commented Apr 22, 2022

We're using nextjs but not a full featured version, should document or link out to an explanation of what the differences are
https://nextjs.org/docs/advanced-features/static-html-export#supported-features

basically we dont support server side rendering / api routes, and only support static pages

can also investigate if the bundle can be separated easily from nextjs to actually deploy the service to k8s + static pages on cdn

@davidcheung davidcheung added the good first issue Good for newcomers label Apr 22, 2022
@shashtag
Copy link

Can you please elaborate more on the issue and what is required.

@davidcheung
Copy link
Contributor Author

Yeah goal for now is just to update https://github.com/commit-app-playground/frontend-template/blob/main/templates/README.md so it lets users know even though Next.js supports server-side rendering and API routes, our template is designed only to build a static bundle therefore only supports https://nextjs.org/docs/advanced-features/static-html-export#supported-features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants