feat(data table manager): add property to disable dropdown options in… #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data table settings
ddouglasz
requested review from
stephsprinkle,
jaikamat,
tylermorrisford,
ByronDWall and
misama-ct
and removed request for
a team
🦋 Changeset detectedLatest commit: 2923046 The changes in this PR will be included in the next version bump. This PR includes changesets to release 98 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
misama-ct
reviewed
Oct 9, 2024
| @@ -34,6 +34,7 @@ type MappedColumns = Record<string, TColumnData>; | |||
| export type TDropdownOption = { | |||
| value: string; | |||
| label: string; | |||
| isDisabled?: boolean; | |||
There was a problem hiding this comment.
Not sure if this shows up in the README.md, but maybe just run yarn generate-readmes to figure out if something changed and commit if necessary.
obulaworld
reviewed
Oct 9, 2024
| : [ | ||
| { | ||
| value: DISPLAY_SETTINGS, | ||
| isDisabled: true, |
There was a problem hiding this comment.
I thought the value of this will come from customSettings and not a hard coded true. or am I missing it?
There was a problem hiding this comment.
Good question. In a sense, we are not hard coding it. When you look at the logic that leads to it, we already did a check in a function where the disabled property is passed from the customSettings and then further used to check if we should disable or not
const areCustomColumnSettingsEnabled = Boolean(
props.customColumnManager &&
!props.customColumnManager?.disableCustomColumnManager
);
There was a problem hiding this comment.
@ddouglasz Okay I understand now. So we will now have to make use of the areCustomColumnSettingsEnables prop.
There was a problem hiding this comment.
We will pass the disableCustomColumnManager through the customColumnManager object.
obulaworld
approved these changes
Oct 9, 2024
…wn should not display
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the migration to the dropdown options for the data table manager, we missed the proper behaviuor of the data table when disabled
This pull request properly introduces the expected feature to the data table manager component, allowing dropdown options to be disabled. .