Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Text.Detail): forward id prop when as prop is not defined #2866

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

ragafus
Copy link
Contributor

@ragafus ragafus commented Jul 25, 2024

Closes #2867

Summary

Forwards Text.Detail id prop in all circumstances.

Description

See full context in #2867

@ragafus ragafus self-assigned this Jul 25, 2024
Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 0:28am

Copy link

changeset-bot bot commented Jul 25, 2024

🦋 Changeset detected

Latest commit: 4614a36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 96 packages
Name Type
@commercetools-uikit/text Patch
@commercetools-uikit/calendar-utils Patch
@commercetools-uikit/collapsible-panel Patch
@commercetools-uikit/data-table-manager Patch
@commercetools-uikit/field-label Patch
@commercetools-uikit/label Patch
@commercetools-uikit/loading-spinner Patch
@commercetools-uikit/messages Patch
@commercetools-uikit/pagination Patch
@commercetools-uikit/primary-action-dropdown Patch
@commercetools-uikit/progress-bar Patch
@commercetools-uikit/stamp Patch
@commercetools-uikit/tag Patch
@commercetools-uikit/flat-button Patch
@commercetools-uikit/icon-button Patch
@commercetools-uikit/link-button Patch
@commercetools-uikit/primary-button Patch
@commercetools-uikit/secondary-button Patch
@commercetools-uikit/secondary-icon-button Patch
@commercetools-uikit/async-creatable-select-input Patch
@commercetools-uikit/async-select-input Patch
@commercetools-uikit/creatable-select-input Patch
@commercetools-uikit/date-input Patch
@commercetools-uikit/date-range-input Patch
@commercetools-uikit/date-time-input Patch
@commercetools-uikit/localized-multiline-text-input Patch
@commercetools-uikit/localized-rich-text-input Patch
@commercetools-uikit/localized-text-input Patch
@commercetools-uikit/search-select-input Patch
@commercetools-uikit/select-utils Patch
@commercetools-frontend/ui-kit Patch
@commercetools-uikit/data-table Patch
@commercetools-uikit/async-creatable-select-field Patch
@commercetools-uikit/async-select-field Patch
@commercetools-uikit/creatable-select-field Patch
@commercetools-uikit/date-field Patch
@commercetools-uikit/date-range-field Patch
@commercetools-uikit/date-time-field Patch
@commercetools-uikit/localized-multiline-text-field Patch
@commercetools-uikit/localized-text-field Patch
@commercetools-uikit/money-field Patch
@commercetools-uikit/multiline-text-field Patch
@commercetools-uikit/number-field Patch
@commercetools-uikit/password-field Patch
@commercetools-uikit/radio-field Patch
@commercetools-uikit/search-select-field Patch
@commercetools-uikit/select-field Patch
@commercetools-uikit/text-field Patch
@commercetools-uikit/time-field Patch
@commercetools-uikit/field-errors Patch
@commercetools-uikit/field-warnings Patch
@commercetools-uikit/localized-money-input Patch
@commercetools-uikit/input-utils Patch
@commercetools-uikit/multiline-text-input Patch
@commercetools-uikit/rich-text-input Patch
@commercetools-uikit/buttons Patch
@commercetools-uikit/selectable-search-input Patch
@commercetools-uikit/dropdown-menu Patch
@commercetools-uikit/search-text-input Patch
@commercetools-uikit/inputs Patch
@commercetools-uikit/checkbox-input Patch
@commercetools-uikit/money-input Patch
@commercetools-uikit/select-input Patch
@commercetools-uikit/fields Patch
@commercetools-uikit/number-input Patch
@commercetools-uikit/password-input Patch
@commercetools-uikit/radio-input Patch
@commercetools-uikit/rich-text-utils Patch
@commercetools-uikit/text-input Patch
@commercetools-uikit/time-input Patch
@commercetools-uikit/toggle-input Patch
@commercetools-uikit/design-system Patch
@commercetools-uikit/calendar-time-utils Patch
@commercetools-uikit/hooks Patch
@commercetools-uikit/i18n Patch
@commercetools-uikit/localized-utils Patch
@commercetools-uikit/utils Patch
@commercetools-uikit/accessible-hidden Patch
@commercetools-uikit/avatar Patch
@commercetools-uikit/card Patch
@commercetools-uikit/collapsible-motion Patch
@commercetools-uikit/collapsible Patch
@commercetools-uikit/constraints Patch
@commercetools-uikit/grid Patch
@commercetools-uikit/icons Patch
@commercetools-uikit/link Patch
@commercetools-uikit/notifications Patch
@commercetools-uikit/tooltip Patch
@commercetools-uikit/view-switcher Patch
@commercetools-uikit/accessible-button Patch
@commercetools-uikit/spacings-inline Patch
@commercetools-uikit/spacings-inset-squish Patch
@commercetools-uikit/spacings-inset Patch
@commercetools-uikit/spacings-stack Patch
@commercetools-uikit/spacings Patch
visual-testing-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@misama-ct misama-ct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙇

Copy link
Contributor

@ddouglasz ddouglasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 💯

@ddouglasz
Copy link
Contributor

No ux/ui changes. Doesn't require designer approval before merging.

@ddouglasz ddouglasz merged commit aae591e into main Jul 26, 2024
7 checks passed
@ddouglasz ddouglasz deleted the rg-detail-forward-id branch July 26, 2024 07:16
@ct-changesets ct-changesets bot mentioned this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Text.Detail> Missing id forwarding results in a difficulty for testing field components
3 participants