-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<DataTable>: No width limit when condensing or expanding columns #2564
Comments
@jocelyn-dunkley I can answer a few of the above issues.
The table columns are not fixed and as a result, users can add 'n' columns according to their wishes. So even if you expand beyond the viewport, the table becomes horizontally scrollable. You don't have to expand your browser size, instead you can simply scroll the table horizontally. If we prevent that, then the table becomes too congested with so many columns.
In addition to the above explanation, Some of our customers don't use the default columns, instead they add attributes and other columns via column manager, they set columns of different widths according to their usage since they can access them by scrolling horizontally.
Our Rewe customer have showed us their minimal design. They shrink the "Status column" so much, that only the dot icon was visible in our previous MC. Infact they mentioned this issue after our new design change. So they want to keep the column to be so small, that the information they need is observed without taking up more space. |
Yes, we used to have MAX_HEIGHT for table and the bottom pagination was always visible. But during the redesign phase, we ran into few issues and it was decided to remove the max height prop and that's why you don't see the footer. |
Could we explore the max height idea again? Because otherwise the page structure is way too fluid and you don't know when things end. |
These are all related to the same issue (I believe) so I have put all my observations here. Please let me know if I should create separate issues for some of them.
Describe the bug
Expected behavior
Issue 1: I expect to only expand the width to the screen size and nothing more. If I increase or decrease the browser width I expect the table to expand or contract along with it.
Issue 2: I expect that the last column has its limit and the 2nd to last column doesn't override it. All the columns stay within the browser width.
Issue 3: I expect the column width limit to be when the column header text is wrapped and the sort option is still visible.
Something like this:
Right now it is this:
Also the left padding should adjust with the width so the padding is always even.
Issue 4: I expect the whole table width to stick to the 100% width of the browser. The column widths will adjust within that. But the whole table width should not move.
Screenshots
The text was updated successfully, but these errors were encountered: