Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't make InfoModalPage scrollable? Or use Emotion styled components? #2157

Open
jtabone16 opened this issue Mar 28, 2022 · 4 comments
Open

Comments

@jtabone16
Copy link

jtabone16 commented Mar 28, 2022

I can't figure out how to make InfoModalPage scrollable. I've tried styling InfoModalPage as a styled component with no luck. I also noticed Emotion styled components don't even render in the DOM. How can I make InfoModalPage scrollable when there's vertical overflow?

@emmenko
Copy link
Member

emmenko commented Mar 29, 2022

Hi 👋,

The modal components already have the content part scrollable. You can check the examples here:

https://docs.commercetools.com/custom-applications/api-reference/commercetools-frontend-application-components#infomodalpage

2022-03-29 09 26 11

Can you maybe describe a bit more your use case if you are expecting something else? Thanks

@jtabone16
Copy link
Author

Screen Shot 2022-03-29 at 8 38 10 AM

@emmenko this global style defined in ApplicationShell was preventing the modal from being fully scrollable. It was scrollable to an extent, but there was some content stuck on the bottom. I ended up adding this ugly bit of code to override it, which works.

Screen Shot 2022-03-29 at 8 39 19 AM

@emmenko
Copy link
Member

emmenko commented Mar 29, 2022

Hmm, I'm still confused as to what the problem is.

Can you provide a screenshot or a gif to show the original problem you had and the expected behavior you are trying to have?

@jtabone16
Copy link
Author

jtabone16 commented Mar 29, 2022

Huh weird I'm seeing different behaviors in the local and deployed apps. Locally, I'm seeing the scrolling issue. However, the deployed app is fine. See the gif below:

Screen Recording 2022-03-29 at 02 53 35 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants