Skip to content

Add basic devcontainer #7819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benceruleanlu wants to merge 3 commits into from
Closed

Add basic devcontainer #7819

benceruleanlu wants to merge 3 commits into from

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Apr 26, 2025 •
edited
Loading

Future:

  1. Simplify setup process for devs based on their GPU. This devcontainer expects the devs to pass their own index urls when installing torch.
  2. Prebuild images
  3. Reference this devcontainer in some README, add note saying they still have to pass their own index url when installing torch

@benceruleanlu benceruleanlu marked this pull request as draft April 27, 2025 01:44
@benceruleanlu benceruleanlu marked this pull request as ready for review April 27, 2025 02:36
@benceruleanlu benceruleanlu closed this by deleting the head repository May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@comfyanonymous comfyanonymous Awaiting requested review from comfyanonymous comfyanonymous is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benceruleanlu @ctrlbenlu