Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookies not being saved correctly #7

Closed
marshalllamb opened this issue May 29, 2017 · 6 comments
Closed

Cookies not being saved correctly #7

marshalllamb opened this issue May 29, 2017 · 6 comments

Comments

@marshalllamb
Copy link

salesforce.com sets 3 cookies on responses to handshakes and subscribes, but the logic in the XMLHttpRequest send() function is preserving cookies as individual array values instead of collapsing them into a single Cookie header. I modified the logic as follows, and it works:

    for (var i = 0; i < _cookies.length; ++i) {
        _config.headers['Cookie'] = _config.headers['Cookie'] + _cookies[i] + ';';
    }
@sbordet
Copy link
Member

sbordet commented May 29, 2017

What version are you using ? This is supposed to be fixed in #2.

@marshalllamb
Copy link
Author

1.0.0-BETA0

@sbordet
Copy link
Member

sbordet commented May 29, 2017

Please install the version at tag beta, should be 1.0.0-BETA3.

@marshalllamb
Copy link
Author

Thanks. That works.

Would you also add support for https? I doctored the require to be for 'https' instead of 'http' since the Bayeux server I'm connecting to only supports https. I can open another Issue if you want.

@sbordet
Copy link
Member

sbordet commented May 29, 2017

The https issue is already resolved by #6. It's not been published to NPM yet, though.

@sbordet
Copy link
Member

sbordet commented Jul 4, 2017

https support landed in 1.0.0-BETA4.

@sbordet sbordet closed this as completed Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants