Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a Shellable[Option[T: Shellable]] #166

Closed
lihaoyi opened this issue Apr 20, 2023 · 2 comments
Closed

Provide a Shellable[Option[T: Shellable]] #166

lihaoyi opened this issue Apr 20, 2023 · 2 comments
Milestone

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Apr 20, 2023

This should work

@ val x: Option[String] = Some("cat") 
x: Option[String] = Some(value = "cat")

@ os.proc(x, ".editorconfig").call() 
cmd1.sc:1: type mismatch;
 found   : Option[String]
 required: os.Shellable
val res1 = os.proc(x, ".editorconfig").call()
                   ^
Compilation Failed
@lefou
Copy link
Member

lefou commented Apr 20, 2023

I had thought, we already support it with IterableShellable, but turns out, Option isn't an Iterable but an IterableOnce.

@lihaoyi
Copy link
Member Author

lihaoyi commented Jan 1, 2024

Looks like this is fixed in #171

@lihaoyi lihaoyi closed this as completed Jan 1, 2024
@lefou lefou added this to the 0.9.2 milestone Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants