Solves #345 : optional signing #346
Conversation
* Made gpgPassphrase optional for publishing * Added a flag to remove signing of published artifacts altogether
Baccata
force-pushed
the
issue-345-optional-signing
branch
from
43015ac to
63e49f9
Compare
|
@rockjam want to review this? Since this is mostly your code |
|
Sure, will do |
| @@ -73,32 +73,35 @@ trait PublishModule extends JavaModule { outer => | |||
| } | |||
|
|
|||
| def publish(sonatypeCreds: String, | |||
| gpgPassphrase: String, | |||
| gpgPassphrase: String = "", | |||
There was a problem hiding this comment.
Is it possible to make this argument optional? Same applies to publishAll command
There was a problem hiding this comment.
I don't think it's possible to write a ScoptReader for "absence of values" tbh. However your suggestion to default to null is better than empty string. Addressed : ec362d8
| release: Boolean): define.Command[Unit] = T.command { | ||
| val PublishModule.PublishData(artifactInfo, artifacts) = publishArtifacts() | ||
| new SonatypePublisher( | ||
| sonatypeUri, | ||
| sonatypeSnapshotUri, | ||
| sonatypeCreds, | ||
| gpgPassphrase, | ||
| Some(gpgPassphrase).filter(_.nonEmpty), |
There was a problem hiding this comment.
If having gpgPassphrase parameter optional is not possible, I guess we could have default value as null and wrap it in Option(gpgPassphrase) instead of filtering out an empty string, what do you think?
| case Some(passphrase) => | ||
| %("gpg", "--passphrase", passphrase, "--batch", "--yes", "-a", "-b", fileName) | ||
| case None => | ||
| %("gpg", "--batch", "--yes", "-a", "-b", fileName) |
There was a problem hiding this comment.
Is it useful to sign artifacts without gpgPassphrase ?
There was a problem hiding this comment.
I honestly don't know if it's useful, but I'm following Haoyi's comment :
There was a problem hiding this comment.
Oh, I didn't notice that. All good then
|
@Baccata left some comments |
better than using empty string as default param.
|
@Baccata everything seems to be fine. Will merge once CI goes green |
#345