Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean does not terminate runBackground subprocess on Windows #4260

Closed
lihaoyi opened this issue Jan 7, 2025 · 1 comment · Fixed by #4265
Closed

clean does not terminate runBackground subprocess on Windows #4260

lihaoyi opened this issue Jan 7, 2025 · 1 comment · Fixed by #4265
Milestone
0.12.6

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Jan 7, 2025

Works on Mac/Linux, but we had to disable mill.integration.RunBackgroundTests.clean below

https://github.com/com-lihaoyi/mill/pull/4259/files#diff-750adfa04c2c48664c29ccb9e403245c36fbbeb14954088c65970f27391f7949R41
@lihaoyi
Copy link
Member Author

lihaoyi commented Jan 7, 2025

Seems to be something to do with clean failing to delete the .mill-background-process-lock file that the runBackground process uses to indicate liveness, which causes clean to stop early and fail to delete the other .mill-background-process-uuid file necessary to terminate the subprocess

@lihaoyi lihaoyi mentioned this issue Jan 8, 2025
Merged
@lihaoyi lihaoyi closed this as completed in 775451f Jan 8, 2025
@lefou lefou added this to the 0.12.6 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.6
Development

Successfully merging a pull request may close this issue.

Use ignoreErrors = true to make clean work on runBackground subprocesses on windows lihaoyi/mill-1
2 participants
@lihaoyi @lefou