Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hello-world and todo-mvc Quarkus examples (1000USD bounty) #3549

Open
lihaoyi opened this issue Sep 15, 2024 · 16 comments
Open

Add hello-world and todo-mvc Quarkus examples (1000USD bounty) #3549

lihaoyi opened this issue Sep 15, 2024 · 16 comments
Labels

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Sep 15, 2024


From the maintainer Li Haoyi: I'm putting a 1000USD bounty on this issue, payable by bank transfer on a merged PR implementing this.


Mill's example test suite has examples for hello-world and todo-mvc projects using in Java using Spring-Boot and Micronaut built using Mill (https://github.com/com-lihaoyi/mill/tree/main/example/javalib/web). They're not super fleshed out, but they exist.

We should add similar hello-world/todo-mvc examples for the Quarkus web framework, which according to the IntelliJ dev survey is relatively popular (between Spring-Boot and Micronaut https://www.jetbrains.com/lp/devecosystem-2023/java/)

@lihaoyi lihaoyi added the bounty label Sep 15, 2024
@lolgab
Copy link
Member

lolgab commented Sep 16, 2024

I'm giving a shot to this.

@lolgab
Copy link
Member

lolgab commented Sep 17, 2024

quarkus, in its maven and gradle plugins, does some code generation which seems to be necessary to create the main method to run applications. I'm going to create a contrib module to mimic what we need from the Maven plugin.
Another missing thing which would be nice to have, is support for pom artifacts to centralize the version management for a framework.
In quarkus you add:

  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>io.quarkus</groupId>
        <artifactId>quarkus-bom</artifactId>
        <version>${quarkus.platform.version}</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
    </dependencies>
  </dependencyManagement>

And then you can add dependencies without setting the version, which will be automatically derived from the pom in quarkus-bom. I think this could be a nice addition to mill (maybe we could have dependencies like ivy"groupid:artifactid" without version, and derive the version from the pom artifacts.
But I'm not going to work on this in the scope of quarkus.

@lefou
Copy link
Member

lefou commented Sep 17, 2024

The import-scope Maven dependencies are called BOM - Bill of Material. There are open requests for it in Mill and coursier:

I think @alexarchambault will work on it in the next months (#3496).

@llvee
Copy link

llvee commented Sep 23, 2024

@lolgab Did you complete this? If not maybe I will give this a shot in 24 hours from now.

@lolgab
Copy link
Member

lolgab commented Sep 23, 2024

I haven't completed it yet.

@llvee
Copy link

llvee commented Sep 23, 2024

@lolgab Would you like some help with it? Have you made a lot of progress?

@llvee
Copy link

llvee commented Oct 14, 2024

@lolgab Have you made any new progress on this?

@lolgab
Copy link
Member

lolgab commented Oct 14, 2024

No, I haven't. Feel free to work on it 👍

@lihaoyi lihaoyi changed the title Add hello-world and todo-mvc Quarkus examples (500USD bounty) Add hello-world and todo-mvc Quarkus examples (1000USD bounty) Dec 11, 2024
@lihaoyi
Copy link
Member Author

lihaoyi commented Dec 11, 2024

Bumping this up from 500 to 1000USD

@himanshumahajan138
Copy link
Contributor

@lihaoyi Working on this (Have Read Docs and Seems it can be done)

@himanshumahajan138
Copy link
Contributor

quarkus, in its maven and gradle plugins, does some code generation which seems to be necessary to create the main method to run applications.

@lolgab could u please provide me some documentation or some link which will guide me for this

Actually i got some understanding but not properly able to understand what's going on internally
please give some brief if possible

@lolgab
Copy link
Member

lolgab commented Feb 5, 2025

I haven't investigated a lot, but you need to reimplement for mill the maven plugin for quarkus

@himanshumahajan138
Copy link
Contributor

@lolgab means we have to create proper plugin first of all then use that plugin as dependency in our examples

what u think we can use the already available codes in the link you gave

looks hard than it looks 😶

@himanshumahajan138
Copy link
Contributor

himanshumahajan138 commented Feb 6, 2025

@lolgab what if we use the "quarkus cli" for creating and running the app

like user have to install the quarkus cli just like they install java or other required libs

@lolgab
Copy link
Member

lolgab commented Feb 6, 2025

It could work but it's very inefficient since the cli is a thin wrapper to the Maven plugin. So mill will call Maven under the hood which is not ideal.
Yes, it's harder than it looks, but it's totally doable if you have the motivation.
At first you can implement the plugin as part of the example build, extracting as a contrib module is easy afterwards.

@himanshumahajan138
Copy link
Contributor

@lolgab I know i should not ask like this but i am motivated and have will to complete this so i need some help regarding this could u please provide me some outer guide like roadmap to reach to end point not only for bounty but in a sense to learn something professionally

TBH I can do this but don't know how to start and what reference to take as example to work on this

Hope U Understand !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants