Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splat is no longer avaiable for Cross Module #2685

Closed
sequencer opened this issue Aug 5, 2023 · 1 comment
Closed

splat is no longer avaiable for Cross Module #2685

sequencer opened this issue Aug 5, 2023 · 1 comment
Labels
invalid This issue is invalid or lacks required information
Milestone

Comments

@sequencer
Copy link
Contributor

sequencer commented Aug 5, 2023

I'm using splat, aka :_* in Cross for cross module auto detection, e.g.

val scalaVersions = Seq("2.13.11", "2.13.10")
object somemodule extends Cross[SomeModule](scalaVersions : _*)
trait SomeModule extends Cross.Module[String]

However after #2511, it makes type check failed:

type mismatch;
[error]  found   : Seq[String]
[error]  required: Seq[mill.define.Cross.Factory[build.this.SomeModule]]
[error] object somemodule extends Cross[SomeModule](scalaVersions : _*)
[error]                                              ^
[error] one error found

I have been using this feature in mill 0.10, e.g.
https://github.com/sequencer/vector/blob/319d2989099f4abd979421180f2cab5ea1412147/build.sc#L235

will this feature be added back in mill 0.11+?

@sequencer
Copy link
Contributor Author

OK, I found I can directly pass scalaVersions now, that's awesome.

@lefou lefou added the invalid This issue is invalid or lacks required information label Aug 9, 2023
@lefou lefou added this to the 0.11.0-M9 milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This issue is invalid or lacks required information
Projects
None yet
Development

No branches or pull requests

2 participants