Skip to content

Can't View More Than 11 Reps Per Object #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miqrogroove opened this issue Sep 15, 2024 · 2 comments
Open

Can't View More Than 11 Reps Per Object #128

miqrogroove opened this issue Sep 15, 2024 · 2 comments

Comments

@miqrogroove
Copy link
Contributor

When an object has more than 11 representations, all additional reps are null in the the slide list.

if (sizeof($va_reps) > 10) { break(2); }

In displayHelpers.php::caRepresentationViewerHTMLBundles() when the output array is appended with an 11th value (count > 10) the function breaks both loops and returns the first 11 values.

This bug appears to affect all branches.

@collectiveaccess
Copy link
Owner

It's a limit that was intentionally added at the request of users back in the day. The idea was to prevent unmanageable lists of media on records where cataloguers had added many many images, often in error.

It would be better to make this configurable, but the limit is still something that some users want/need.

@miqrogroove
Copy link
Contributor Author

miqrogroove commented Sep 15, 2024

This needs to be reconciled with themeHelpers.php::caObjectRepresentationThumbnails() returning an unlimited list of thumbnails. It is definitely a bug of some kind when one feature is broken by another feature's intentional limitation.

With the slide list and thumbnail list having different ordering, this will be a bit of a challenge. Any solution must also consider that the primary representation could be more than position 11 among existing representations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants