Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can edit a link field in a block inline (e.g. teaser block or image block) #68

Open
Tracked by #5
djay opened this issue Jun 24, 2024 · 2 comments
Open
Tracked by #5

Comments

@djay
Copy link
Member

djay commented Jun 24, 2024

Some blocks have links fields rather than richtext ones like in #35.

These should be able to be clicked on to edit the url inline similar to #35.

Don't think there is a design for this in figma.

This will also help being able to to click on blocks without it navigating away accidentally

@djay djay changed the title I can edit a link field in a block inline I can edit a link field in a block inline (e.g. teaser block or image block) Jul 9, 2024
@djay
Copy link
Member Author

djay commented Aug 17, 2024

We should make sure how the UI works that it should allow for editing a link at the same time as an image such as on the Image block.

Maybe that means that editing the link is via a button on the slate bar instead of just clicking on it?

@djay
Copy link
Member Author

djay commented Dec 3, 2024

I think the UI should be the similar as for slate.

  1. click on the teaser in a place that would be linked (could also be text editable)
    • difference is you don't have to select the text you want to turn into a link
    • if something is both text and link editable then the maybe data-field-editable="heading,url"?
  2. link icon appears on the toolbar
  3. click link and enter/select url.
  4. repeat to edit.

Note

  • We don't support optional browsing to another page
    • if its needed we can add it into the link widget later
  • we do need to disable any links or buttons for the frontend so they don't have to write complex code.
    • this prevents accidentally browsing to another page while editing
    • not sure how hard that is
  • for something like a teaser where it makes sense to start by selecting the link to init the rest of the content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant