Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error #13

Closed
dest81 opened this issue Dec 30, 2014 · 6 comments
Closed

error #13

dest81 opened this issue Dec 30, 2014 · 6 comments

Comments

@dest81
Copy link

dest81 commented Dec 30, 2014

Please fix:

--- a/collective/jsonify/wrapper.py
+++ b/collective/jsonify/wrapper.py
@@ -125,7 +125,7 @@ class Wrapper(dict):
         """ Local roles of object
             :keys: _local_roles
         """
-        self['_local_roles'] = {}
+        self['_ac_local_roles'] = {}
         if getattr(self.context, '__ac_local_roles__', False):
             for key, val in self.context.__ac_local_roles__.items():
                 if key is not None:
                    self['_ac_local_roles'][key] = val
@djowett
Copy link
Contributor

djowett commented Dec 31, 2014

+1 - but fix the docstring too & collective.jsonmigrator needs to match up as well.
@realefab, @thet ?

@djowett
Copy link
Contributor

djowett commented Dec 31, 2014

Correction, this is fixed in #12 by @thet where the key remains as '_local_roles'. If it's ready?
collective.jsonmigrator still should match though.

@thet
Copy link
Member

thet commented Jan 2, 2015

my pull-request is ready to be merged, IMO...

@thet
Copy link
Member

thet commented Jan 2, 2015

i'm going to change that in my pull request to _ac_local_roles. the blueprint in collective.jsonmigrator uses that as default key. looks like, the key in collective.jsonify was a typo. (altough, there is a xmlwalker.cfg example in plone.app.transmogrify, which uses the _local_roles key, but however...)

@thet
Copy link
Member

thet commented Jan 2, 2015

@dest81 should be fixed by: #12

@thet thet closed this as completed Jan 2, 2015
@dest81
Copy link
Author

dest81 commented Jan 3, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants