Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reconciler Active/Inactive Concurrency Configuration #29

Merged
merged 2 commits into from
May 18, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented May 16, 2020

Motivation

Fix #28.

Solution

After some initial consideration to create a shared reconciliation goroutine pool (that always preferred active reconciliations to inactive reconciliations), I decided to stick with the 2 pool route and add a configuration to control the concurrency of each.

There are certain cases where you would not always want to prefer active reconciliations to inactive (for example, in the case where there are so many active reconciliations queued that you never do inactive reconciliations) so I opted for this dual configuration option en lieu of developing some complicated heuristic.

@coveralls
Copy link

coveralls commented May 16, 2020

Pull Request Test Coverage Report for Build 1279

  • 15 of 18 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 68.546%

Changes Missing Coverage Covered Lines Changed/Added Lines %
reconciler/reconciler.go 9 12 75.0%
Totals Coverage Status
Change from base Build 1257: 0.03%
Covered Lines: 1009
Relevant Lines: 1472

💛 - Coveralls

@patrick-ogrady patrick-ogrady force-pushed the patrick/reconciler-concurrency-configuration branch from cc7c216 to 41088a3 Compare May 16, 2020 00:39
@patrick-ogrady patrick-ogrady merged commit cea5733 into master May 18, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/reconciler-concurrency-configuration branch May 18, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Allow Separate Configuration for Active/Inactive Reconciliation Concurrency
3 participants