[storage] Balance Exemption Overhaul #205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because many blockchains apply rewards after the parent block is processed (usually before transactions in the next block are applied), adjusting the computed balance to equal the live balance of the parent block before applying balance changes doesn't guarantee that a computed account balance won't go negative (if a transaction in the new block spends the new rewards). This PR modifies the balance exemption logic to compare the computed balance after applying operations but before being checked for a negative value.
Changes