Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reconciler] Re-enqueue accounts when context canceled #196

Merged
merged 7 commits into from
Oct 19, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Oct 19, 2020

This PR ensures that accounts being reconciled when context is canceled are re-added to their respective reconciliation queue instead of being dropped (this can lead to a < 100% coverage with certain rosetta-cli end conditions).

Changes

  • Create constant for inactive reconciliations
  • re-enqueue balance changes if context canceled
  • add tests

@coveralls
Copy link

coveralls commented Oct 19, 2020

Pull Request Test Coverage Report for Build 9269

  • 30 of 55 (54.55%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 78.312%

Changes Missing Coverage Covered Lines Changed/Added Lines %
reconciler/reconciler.go 30 55 54.55%
Files with Coverage Reduction New Missed Lines %
reconciler/reconciler.go 1 82.94%
Totals Coverage Status
Change from base Build 9209: -0.01%
Covered Lines: 6738
Relevant Lines: 8604

💛 - Coveralls

@patrick-ogrady patrick-ogrady force-pushed the patrick/failed-reconciliations-counter branch from f000a5d to 25801e1 Compare October 19, 2020 18:45
yfl92
yfl92 previously approved these changes Oct 19, 2020
@patrick-ogrady patrick-ogrady merged commit 1f2b345 into master Oct 19, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/failed-reconciliations-counter branch October 19, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants