Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage] Only update last reconciled if index > #194

Merged
merged 7 commits into from
Oct 16, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Oct 16, 2020

Related: #187

As a result of using buffered channels in the reconciler, we need to protect against "out of date" updates to the last_reconciled information in storage.

Changes

  • Only update last reconciled if index >
  • Add block exists method to block_storage (enables block pruning before reconciliation)
  • Change BlockExists to CanonicalBlock in reconciler

@heimdall-asguard
Copy link

If Heimdall is stuck, please click the following link: https://heimdall-public.cbhq.net/v1/pull_request/stuck?pr_number=194&repository=coinbase/rosetta-sdk-go

@coveralls
Copy link

coveralls commented Oct 16, 2020

Pull Request Test Coverage Report for Build 9185

  • 21 of 25 (84.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 78.324%

Changes Missing Coverage Covered Lines Changed/Added Lines %
storage/block_storage.go 14 18 77.78%
Totals Coverage Status
Change from base Build 9118: 0.006%
Covered Lines: 6710
Relevant Lines: 8567

💛 - Coveralls

@patrick-ogrady patrick-ogrady merged commit 46c5411 into master Oct 16, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/reconciler-end-condition branch October 16, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants