-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Constructor] Rosetta Constructor DSL #176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Heimdall is stuck, please click the following link: https://heimdall-public.cbhq.net/v1/pull_request/stuck?pr_number=176&repository=coinbase/rosetta-sdk-go |
Pull Request Test Coverage Report for Build 8526
💛 - Coveralls |
patrick-ogrady
force-pushed
the
patrick/workflow-dsl
branch
from
October 4, 2020 19:35
adad6a9
to
159b8bf
Compare
patrick-ogrady
changed the title
[Constructor] Create a DSL
[Constructor] Babel: Rosetta Constructor DSL
Oct 5, 2020
patrick-ogrady
changed the title
[Constructor] Babel: Rosetta Constructor DSL
[Constructor] Rosetta Constructor DSL
Oct 5, 2020
patrick-ogrady
force-pushed
the
patrick/workflow-dsl
branch
from
October 5, 2020 16:40
5d25bee
to
64f717d
Compare
patrick-ogrady
requested review from
juliankoh,
annieke,
qiwu7,
yfl92 and
cindyxkuang
October 5, 2020 16:41
patrick-ogrady
force-pushed
the
patrick/workflow-dsl
branch
from
October 5, 2020 16:44
64f717d
to
1c10c09
Compare
qiwu7
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🔥 this is awesome! great documentation on this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: coinbase/mesh-cli#137
This PR adds a simple DSL (domain-specific language) for writing
Workflows
. For now, we are just calling thisRosetta Constructor DSL
but we could introduce a name for this "language" if it gets more sophisticated.Old Way
New Way
Changes
set_variable
or just equalconstructor
packageconstructor
to top level READMEMath
parsingWorkflows
don't have same namesScenarios
don't have same nameFuture PR
To build a wallet using this DSL, all you need to do is populate state with some values from a request before running.