Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC-20 tokens support #110

Open
chernyshev opened this issue Apr 2, 2022 · 3 comments
Open

ERC-20 tokens support #110

chernyshev opened this issue Apr 2, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@chernyshev
Copy link

Is it possible to transfer ERC-20 tokens using the construction API of the rosetta-ethereum implementation?

@chernyshev chernyshev added the bug Something isn't working label Apr 2, 2022
@shrimalmadhur
Copy link
Contributor

@chernyshev right now the current implementation doesn't support erc20 construction. We are working on a generic evm based sdk which will support ERC20 construction out of the box for most EVM based chains. We will open source that and replace the current rosetta-ethereum implementation with that once it is ready.

@dvc94ch
Copy link
Contributor

dvc94ch commented Oct 3, 2022

not just that but as far as I can tell there is no way to construct a valid transaction period.

WARN [10-03|15:00:34.137] Served eth_sendRawTransaction            conn=[::1]:40180     reqid=31 duration="665.875µs" err="insufficient funds for gas * price + value"

if you try to add a transaction fee manually (like the suggested_fee object returned from construction/metadata returns) the payloads endpoint will fail to accept the transaction as it has an "invalid intent". if you do not supply a fee then the transaction gets rejected by geth when you try to submit it.

Is there an ETA on a working ethereum implementation?

@dvc94ch
Copy link
Contributor

dvc94ch commented Oct 3, 2022

take it back. looks like the issue is that there is something wrong with my ecdsa recovery implementation. the recovered public key does not match the signing public key.

EDIT: found the problem. the payload returned by the rosetta api is prehashed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants