Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rosetta-cli check always exits with status code 1 when using --end #20

Closed
abukosek opened this issue May 15, 2020 · 1 comment · Fixed by #25
Closed

rosetta-cli check always exits with status code 1 when using --end #20

abukosek opened this issue May 15, 2020 · 1 comment · Fixed by #25
Labels
bug Something isn't working

Comments

@abukosek
Copy link

Describe the bug
When using the --end option to rosetta-cli check, it always exits with status code 1, even when there are no errors in the output.
This makes it difficult to use as part of an automated continuous-integration workflow or testing suite.

To Reproduce
Steps to reproduce the behavior:

  1. Run rosetta-cli check --end 42; echo $?.

Expected behavior
If there are no validation errors, an exit code of 0 should be returned. Exit code 1 should be returned only if validation errors have occurred.

@abukosek abukosek added the bug Something isn't working label May 15, 2020
@patrick-ogrady
Copy link
Contributor

Thanks for posting this issue. I think this is a great idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants