New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defining activation functions in several places #125

Open

rmisener opened this issue Oct 9, 2023 · 0 comments

Member

rmisener commented Oct 9, 2023

We currently define the activation functions for neural network nodes in several places:

https://github.com/cog-imperial/OMLT/blob/main/src/omlt/neuralnet/layer.py --> Line 112 - 122
https://github.com/cog-imperial/OMLT/blob/main/src/omlt/neuralnet/activations/smooth.py --> Lines 4 - 43

This is a problem because anyone adding a new activation function (or debugging an existing activation function) will have to add the new activation function twice. Additionally, softplus seems to be missing from one of the two places where we define activation functions (https://github.com/cog-imperial/OMLT/blob/main/src/omlt/neuralnet/layer.py).

rmisener mentioned this issue

add graph neural networks #110

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment